Dual command hook #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents the task bars from leaping into the foreground and creating tons of windows that annoy the user
Setting the frame attributes wasn't consistently achieving the intent.
psionic-k
force-pushed
the
dual-command-hook
branch
from
690c5e3
to
7ca2443
Compare
|
This PR is ready for review. |
this makes it easier for users to ignore vast swaths of commands Signed-off-by: Psionik K <[email protected]>
Signed-off-by: Psionik K <[email protected]>
Signed-off-by: Psionik K <[email protected]>
This enables upstream logic to dictate downstream behavior Signed-off-by: Psionik K <[email protected]>
Reading command keys post hook failed for C-g. It is frequently nil in the post hook. Signed-off-by: Psionik K <[email protected]>
Signed-off-by: Psionik K <[email protected]>
psionic-k
force-pushed
the
dual-command-hook
branch
2 times, most recently
from
853effe
to
b5d600f
Compare
|
バク が見付かして アプディト しました. I found a bug and force pushed my branch |
Signed-off-by: Psionik K <[email protected]>
The value of `this-command` is not updated by every bound command. Commands such as `counsel-M-x` and `universal-argument` do not update `this-command` and so we must use the value of `this-command` we stored during the pre-command hook. Signed-off-by: Psionik K <[email protected]>
This one kind of confused me Signed-off-by: Psionik K <[email protected]>
Signed-off-by: Psionik K <[email protected]>
psionic-k
force-pushed
the
dual-command-hook
branch
from
b5d600f
to
a5911d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@chuntaro Feel free to check these commits and features. I'll move this PR out of draft when I'm done. Please let me know if you decide to change history.
I'm adding features that I just finished developing with the command-log package. The changes are mostly focused at making it easier to show either commands that were issued or commands they delegated out to, helping to illustrate what's happening versus what the binding is.
I'm also fixing some bugs such as task bar pollution from #19
Because I commonly get no reply when working on packages, if I haven't heard anything in about a month I'll presume it's better to detach and take over maintenance.