Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dual command hook #20

Merged
merged 14 commits into from
Nov 23, 2023
Merged

Dual command hook #20

merged 14 commits into from
Nov 23, 2023

Commits on Nov 17, 2023

  1. additional parameters 

    This prevents the task bars from leaping into the foreground and creating tons
of windows that annoy the user
    @psionic-k
    psionic-k committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    161db8c View commit details
    Browse the repository at this point in the history

  2. Add support to ignore commands, such as self-insert-command

    @psionic-k
    psionic-k committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    b366571 View commit details
    Browse the repository at this point in the history

  3. More robust face setup 

    Setting the frame attributes wasn't consistently achieving the intent.
    @psionic-k
    psionic-k committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    43321a1 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2023

  1. support ignore function 

    this makes it easier for users to ignore vast swaths of commands

Signed-off-by: Psionik K <[email protected]>
    @psionic-k
    psionic-k committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    72c4576 View commit details
    Browse the repository at this point in the history

  2. Condense parent logic and add delete-before

    @psionic-k
    psionic-k committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    dae93b1 View commit details
    Browse the repository at this point in the history

  3. switch to post-command hook as the base 

    Signed-off-by: Psionik K <[email protected]>
    @psionic-k
    psionic-k committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    6b12777 View commit details
    Browse the repository at this point in the history

  4. Add pre-command hook (no-op) 

    Signed-off-by: Psionik K <[email protected]>
    @psionic-k
    psionic-k committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    28efc32 View commit details
    Browse the repository at this point in the history

  5. Increasing purity. Pass rather than re-read. 

    This enables upstream logic to dictate downstream behavior

Signed-off-by: Psionik K <[email protected]>
    @psionic-k
    psionic-k committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    5b772e0 View commit details
    Browse the repository at this point in the history

  6. store this-command-keys in pre-hook 

    Reading command keys post hook failed for C-g.  It is frequently nil in the post
hook.

Signed-off-by: Psionik K <[email protected]>
    @psionic-k
    psionic-k committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    2b1b707 View commit details
    Browse the repository at this point in the history

  7. purify keypression--same-command 

    Signed-off-by: Psionik K <[email protected]>
    @psionic-k
    psionic-k committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    6a8d57b View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2023

  1. Store pre-command this-command and enable preference before render 

    Signed-off-by: Psionik K <[email protected]>
    @psionic-k
    psionic-k committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    e89f7f1 View commit details
    Browse the repository at this point in the history

  2. pre commands that require exception of the post command 

    The value of `this-command` is not updated by every bound command.  Commands
such as `counsel-M-x` and `universal-argument` do not update `this-command` and
so we must use the value of `this-command` we stored during the pre-command hook.

Signed-off-by: Psionik K <[email protected]>
    @psionic-k
    psionic-k committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    39947fd View commit details
    Browse the repository at this point in the history

  3. Change internal name and add docstring 

    This one kind of confused me

Signed-off-by: Psionik K <[email protected]>
    @psionic-k
    psionic-k committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    591a86a View commit details
    Browse the repository at this point in the history

  4. docstrings, package lints 

    Signed-off-by: Psionik K <[email protected]>
    @psionic-k
    psionic-k committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    a5911d3 View commit details
    Browse the repository at this point in the history