-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed 1.2 and 3.2 from the Calendar Baseline per Issue 133 #134
Conversation
After initial review of @adhilto comments these are being recommended for removal. Not only do we concur with the comment regarding this being confusing, but there is also overlap with 1.1 and 3.1, respectively. Lastly, there are is no separate admin control for either 1.2 or 3.2 which makes this more of a general recommendation and not a configuration item for a secure configuration baseline. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to also remove the implementation steps for GWS.CALENDAR.1.2v0.1 and GWS.CALENDAR.3.2v0.1. It looks like this PR only removes the policies.
Removed the implementation steps for removed policies and fixed the drift rules file. |
This one has code impact (policy removal). Does it make sense to also address the code changes via this branch/PR and then once the reviewers are happy with both the content/code changes we can tag in @mitchelbaker-cisa for final review so he doesn't have to watch the previous reviews and go-backs etc? |
Yes Tommy, I like that approach. Once #141 is merged in I'll make the needed code changes to this branch. I'll mark this as blocked until then. |
@jkaufman-mitre What do you think about putting GWS.CALENDAR.1.1 and GWS.CALENDAR.3.1 into the same group? They're both related and that would prevent two singleton groups. Something like this:
|
I just added the needed rego changes. @jkaufman-mitre did you see my earlier comment about putting 1.1 and 3.1 into the same group? I'll hold off on finishing my review until I hear back about that. |
@adhilto I will merge the two together. |
@adhilto Just made the changes to merge the two groups. |
baselines/Google Calendar Minimum Viable Secure Configuration Baseline v0.1.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. Just one more thing, don't forget to update the table of contents to reflect merging the two calendar sharing options groups together.
@adhilto Just fixed the TOC. |
It looks like it might not have pushed correctly, because I'm not seeing the changes on this branch yet. |
…Goggles into calendar-changes-2 Fixed issues
Removed the following policies from the Calendar baseline:
Fixes #133