Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swapped Implementation Step #2 in COMMONCONTROLS.11.4v0.1 and COMMONCONTROLS.11.5v0.1 per Issue 143 #144

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

jkaufman-mitre
Copy link
Collaborator

@jkaufman-mitre jkaufman-mitre commented Jan 9, 2024

🗣 Description

In COMMONCONTROLS.11.4v0.1 and COMMONCONTROLS.11.5v0.1, the implementation step 2 was swapped. When it and put the implementation step under the correct policy.

Fixes #143

💭 Motivation and context

  • This change is required to ensure that the implementation steps listed are under the correct policy identifier

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
  • The relevant issues PR resolves are linked preferably via closing keywords.
  • All relevant type-of-change labels have been added.
  • I have read and agree to the CONTRIBUTING.md document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge Checklist

  • This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
  • Squash all commits into one PR level commit using the Squash and merge button.

✅ Post-merge Checklist

  • Delete the branch to clean up.
  • Close issues resolved by this PR if the closing keywords did not activate.

Copy link
Collaborator

@tmcomeau tmcomeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding label for "code impact" or "non code impact" for this PR and future ones.

@LaurenBassett LaurenBassett merged commit 809fd32 into main Jan 10, 2024
4 checks passed
@LaurenBassett LaurenBassett deleted the pc-common-controls-11.4-11.5 branch January 10, 2024 19:13
@adhilto adhilto added this to the TBD 0.2 Milestone milestone Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The implementation instructions for Common Control 11.4 and 11.5 are in reverse order
4 participants