-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Password Length Policy based on new NIST Guidelines #460
Updating Password Length Policy based on new NIST Guidelines #460
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good. Splitting the policy into Shall/Should is a good idea, especially since it is consistent with NIST policy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the new NIST-800-63B Password Guidelines to the Resources
section of the Policy Group.
https://pages.nist.gov/800-63-4/sp800-63b.html#passwordver
Co-authored-by: David Bui <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One soft recommendation, but approving either way.
Co-authored-by: Alden Hilton <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to update the drift rules in this PR or do that in a separate PR? https://github.com/cisagov/ScubaGoggles/blob/442-new-nist-password-guidelines-%2B-changing-password-length-policy/drift-rules/GWS%20Drift%20Monitoring%20Rules%20-%20Common%20Controls%20as%20of%2011-14-23.csv ?
@buidav I forgot about the drift rules, thanks for the reminder. Added them in. |
* added in split policy with 8 and 15 in commmon controls password length policy * Added nist guidelines to resources section * Made it should be 12, shall be 16 and added resource links for google guidance for 12 and cisa guidance for 16 * Forgot implementation steps as well. * setting to shall 12, should 15 based on internal discussion * added in new resource link * Update baselines/commoncontrols.md Co-authored-by: David Bui <[email protected]> * updated resources * Update baselines/commoncontrols.md Co-authored-by: Alden Hilton <[email protected]> * updating drift rules --------- Co-authored-by: David Bui <[email protected]> Co-authored-by: Alden Hilton <[email protected]>
🗣 Description
[NIST's guidance] (https://pages.nist.gov/800-63-4/sp800-63b.html#passwordver) is: "Verifiers and CSPs SHALL require passwords to be a minimum of eight characters in length and SHOULD require passwords to be a minimum of 15 characters in length." Based on internal discussion we are looking to adopt as split SHALL/SHOULD approach for the policy.
💭 Motivation and context
Closes #442
🧪 Testing
✅ Pre-approval checklist
✅ Pre-merge Checklist
This PR has been smoke tested to ensure main is in a functional state when this PR is merged.Squash and merge
button.✅ Post-merge Checklist