Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Password Length Policy based on new NIST Guidelines #460

Conversation

mdueltgen
Copy link
Collaborator

@mdueltgen mdueltgen commented Oct 4, 2024

🗣 Description

[NIST's guidance] (https://pages.nist.gov/800-63-4/sp800-63b.html#passwordver) is: "Verifiers and CSPs SHALL require passwords to be a minimum of eight characters in length and SHOULD require passwords to be a minimum of 15 characters in length." Based on internal discussion we are looking to adopt as split SHALL/SHOULD approach for the policy.

💭 Motivation and context

Closes #442

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
  • The relevant issues PR resolves are linked preferably via closing keywords.
  • All relevant type-of-change labels have been added.
  • I have read and agree to the CONTRIBUTING.md document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.

✅ Pre-merge Checklist

  • This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
  • Squash all commits into one PR level commit using the Squash and merge button.

✅ Post-merge Checklist

  • Delete the branch to clean up.
  • Close issues resolved by this PR if the closing keywords did not activate.

Copy link
Collaborator

@jkaufman-mitre jkaufman-mitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good. Splitting the policy into Shall/Should is a good idea, especially since it is consistent with NIST policy.

Copy link
Collaborator

@buidav buidav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the new NIST-800-63B Password Guidelines to the Resources section of the Policy Group.
https://pages.nist.gov/800-63-4/sp800-63b.html#passwordver
Resources

@mdueltgen mdueltgen requested a review from buidav October 7, 2024 11:16
@adhilto adhilto marked this pull request as draft October 9, 2024 16:44
@mdueltgen mdueltgen marked this pull request as ready for review October 10, 2024 20:06
@buidav buidav self-requested a review October 10, 2024 20:09
baselines/commoncontrols.md Outdated Show resolved Hide resolved
baselines/commoncontrols.md Outdated Show resolved Hide resolved
@mdueltgen mdueltgen requested a review from buidav October 11, 2024 14:42
@mdueltgen mdueltgen requested a review from adhilto October 14, 2024 15:32
Copy link
Collaborator

@adhilto adhilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One soft recommendation, but approving either way.

baselines/commoncontrols.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@buidav buidav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@buidav buidav self-requested a review October 15, 2024 02:38
@mdueltgen
Copy link
Collaborator Author

@buidav I forgot about the drift rules, thanks for the reminder. Added them in.

@buidav buidav merged commit 11f5571 into driftwood Oct 15, 2024
3 of 5 checks passed
@buidav buidav deleted the 442-new-nist-password-guidelines-+-changing-password-length-policy branch October 15, 2024 16:11
adhilto added a commit that referenced this pull request Oct 15, 2024
* added in split policy with 8 and 15 in commmon controls password length policy

* Added nist guidelines to resources section

* Made it should be 12, shall be 16 and added resource links for google guidance for 12 and cisa guidance for 16

* Forgot implementation steps as well.

* setting to shall 12, should 15 based on internal discussion

* added in new resource link

* Update baselines/commoncontrols.md

Co-authored-by: David Bui <[email protected]>

* updated resources

* Update baselines/commoncontrols.md

Co-authored-by: Alden Hilton <[email protected]>

* updating drift rules

---------

Co-authored-by: David Bui <[email protected]>
Co-authored-by: Alden Hilton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants