Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Various Calendar Implementation Steps/Resources #557

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Fixing Various Calendar Implementation Steps/Resources #557

merged 2 commits into from
Jan 9, 2025

Conversation

mdueltgen
Copy link
Collaborator

@mdueltgen mdueltgen commented Jan 8, 2025 •
edited by buidav
Loading

🗣 Description

Updating various implementation steps and resource links in calendar baseline

💭 Motivation and context

Google Admin console language was updated, so needed to update baseline to reflect what is shown in the admin console.

Closes #514

🧪 Testing

N/A

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
  • The relevant issues PR resolves are linked preferably via closing keywords.
  • All relevant type-of-change labels have been added.
  • I have read and agree to the CONTRIBUTING.md document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.

✅ Pre-merge Checklist

  • This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
  • Squash all commits into one PR level commit using the Squash and merge button.

✅ Post-merge Checklist

  • Delete the branch to clean up.
  • Close issues resolved by this PR if the closing keywords did not activate.

@mdueltgen mdueltgen added this to the Eel milestone Jan 8, 2025
@mdueltgen mdueltgen requested review from buidav and adhilto January 8, 2025 16:52
@mdueltgen mdueltgen self-assigned this Jan 8, 2025
@mdueltgen mdueltgen linked an issue Jan 8, 2025 that may be closed by this pull request
Inaccurate Calendar 3.1/3.2 and 4.1 Implementation Steps/Resources #514
Closed
1 task
@mdueltgen mdueltgen changed the base branch from main to eel January 8, 2025 16:54
buidav
buidav requested changes Jan 9, 2025
View reviewed changes
scubagoggles/baselines/calendar.md Outdated Show resolved Hide resolved
scubagoggles/baselines/calendar.md Outdated Show resolved Hide resolved
@jkaufman-mitre jkaufman-mitre requested a review from buidav January 9, 2025 12:27
@buidav buidav merged commit ea46e80 into eel Jan 9, 2025
4 of 5 checks passed
@buidav buidav mentioned this pull request Jan 9, 2025
Closed
1 task
@buidav buidav deleted the 514-inaccurate-calendar-3132-implementation-steps branch January 9, 2025 14:11
adhilto pushed a commit that referenced this pull request Jan 9, 2025
@mdueltgen @jkaufman-mitre
@buidav @adhilto
Fixing Various Calendar Implementation Steps/Resources (#557)
5428630 
* calendar fixes

* Apply suggestions from code review

Co-authored-by: David Bui <[email protected]>

---------

Co-authored-by: jkaufman-mitre <[email protected]>
Co-authored-by: David Bui <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adhilto adhilto adhilto approved these changes

@buidav buidav buidav approved these changes

Assignees

@mdueltgen mdueltgen

Labels
Baseline Revision Google Calendar
Projects
None yet
Milestone
Eel
Development

Successfully merging this pull request may close these issues.

Inaccurate Calendar 3.1/3.2 and 4.1 Implementation Steps/Resources
4 participants
@mdueltgen @buidav @adhilto @jkaufman-mitre