Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Common Controls 7.1 to SHOULD and update Common Controls Policy Group 17 resource link #558

Merged
merged 4 commits into from
Jan 9, 2025
Merged

Change Common Controls 7.1 to SHOULD and update Common Controls Policy Group 17 resource link #558

merged 4 commits into from
Jan 9, 2025

Conversation

jkaufman-mitre
Copy link
Collaborator

@jkaufman-mitre jkaufman-mitre commented Jan 8, 2025 •
edited by buidav
Loading

🗣 Description

Changed Common Control 7.1 to SHOULD and updated the resource link for Common Control Policy Group 17. Changed Last Modified for Common Control 7.1 to January 2025. Updated the Drift Rule File Updated.

Closes #501

💭 Motivation and context

Came from Internal Discussion

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
  • The relevant issues PR resolves are linked preferably via closing keywords.
  • All relevant type-of-change labels have been added.
  • I have read and agree to the CONTRIBUTING.md document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.

✅ Pre-merge Checklist

  • This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
  • Squash all commits into one PR level commit using the Squash and merge button.

✅ Post-merge Checklist

  • Delete the branch to clean up.
  • Close issues resolved by this PR if the closing keywords did not activate.

@jkaufman-mitre jkaufman-mitre added this to the Eel milestone Jan 8, 2025
@jkaufman-mitre jkaufman-mitre self-assigned this Jan 8, 2025
@buidav buidav changed the title 501 change common controls 71 to should and update common controls 17 resource link Change Common Controls 7.1 to SHOULD and update Common Controls Policy Group 17 resource link Jan 9, 2025
@buidav buidav merged commit 3f9ff5e into eel Jan 9, 2025
9 of 11 checks passed
@buidav buidav deleted the 501-change-common-controls-71-to-should-and-update-common-controls-17-resource-link branch January 9, 2025 03:18
@buidav buidav mentioned this pull request Jan 9, 2025
Closed
1 task
adhilto added a commit that referenced this pull request Jan 9, 2025
@jkaufman-mitre @adhilto
Change Common Controls 7.1 to SHOULD and update Common Controls Polic…
44461f3 
…y Group 17 resource link (#558)

* Changed 7.1 to SHOULD and Fixed CC 17 Resource Link

* Updated Drift Rules

* Updated Date

* Change CommonControls 7.1 to SHOULD in rego

---------

Co-authored-by: Alden Hilton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adhilto adhilto adhilto approved these changes

@buidav buidav buidav approved these changes

@mdueltgen mdueltgen Awaiting requested review from mdueltgen

Assignees

@jkaufman-mitre jkaufman-mitre

Labels
Baseline Revision High
Projects
None yet
Milestone
Eel
Development

Successfully merging this pull request may close these issues.
3 participants
@jkaufman-mitre @buidav @adhilto