-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schema editor integration #25
Open
roll
wants to merge
20
commits into
master
Choose a base branch
from
validation-schema
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 14 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
e70cfd4
Added raw schema editor integration example/workflow
roll 838435e
Updated tableschema-ui integration
roll 5a4cd7a
Removed console.log
roll 5e25b05
Fixed tableschema-ui styling
roll 1fa0f25
Fixed source/schema logic for editor
roll 7c37410
Fixes #27. Close schema editor popup
amercader b1b93b5
Disable preview on schema editor
roll 9c1bd9a
Moved tableschema-ui to fanstatic
roll 7a71de3
Use bootstrap backport style only for bootstrap@2
roll 32e26a7
Fixed schema buttons margin bottom
roll 81f0bf2
Switched from Edit schema button to Infer schema button
roll aecf1db
Removed unused variable
roll f68637f
Allow schema editing
roll 82e2465
Added comment
roll 6e2b8db
Updated comment
roll b24522b
Move CSS to its own file
amercader 2f547b3
Display popup content on BS3
amercader 4c6ad94
Merge branch 'master' into validation-schema
amercader 7919509
Fix css asset name
amercader 78710ae
Merge branch 'master' into validation-schema
amercader File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amercader
Can you please take a look how it works now?
TBH I feel like I'm missing something regarding your comment here - #34 (comment). And because of the bad sound quality haven't got fully your explanation during our call.
Of course, I'm pretty neutral on enabling/disabling the linked schema editing - just curious why the user can't edit the linked schema based on the same approach we have for the create resource page.