-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed emoji panel not being visible #17999
base: master
Are you sure you want to change the base?
Conversation
|
||
/* See: https://github.com/ckeditor/ckeditor5/issues/17964 */ | ||
div.ck.ck-balloon-panel:has( .ck.ck-emoji ) { | ||
z-index: calc( var( --ck-z-dialog ) + 1 ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments archive uses --ck-z-panel
for the z-index
. Could you check if after replacing the variable it still works fine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does not work. See:
ckeditor5/packages/ckeditor5-ui/theme/globals/_zindex.css
Lines 6 to 10 in 26bf48f
:root { | |
--ck-z-default: 1; | |
--ck-z-panel: calc( var(--ck-z-default) + 999 ); | |
--ck-z-dialog: 9999; | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should apply the z-index
via toggling the class in a template.
Something like:
attributes: {
class: [
bind.if( 'isEmojiPanelOpen', 'ck-emoji__panel_open' )
]
}
and then define the z-index
in .ck-emoji__panel_open
class in CSS file:
.ck-emoji__panel_open {
z-index: calc( var( --ck-z-dialog ) + 1 );
}
@@ -138,6 +138,8 @@ export default class EmojiPicker extends Plugin { | |||
this.emojiPickerView = this._createEmojiPickerView(); | |||
} | |||
|
|||
this.emojiPickerView.isEmojiPanelOpen = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am wondering if we could use the binding engine to update the field automatically.
https://ckeditor.com/docs/ckeditor5/latest/framework/deep-dive/observables.html
If it goes well, we could bind the CSS class without defining an additional class property.
Suggested merge commit message (convention)
Other (emoji): Fixed emoji panel not being visible while using it in comments archive. Closes #17964.
Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.