Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed emoji panel not being visible #17999

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
+98 −2
Open

Fixed emoji panel not being visible #17999

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f26ef22
Fixed emoji panel not being visible.
przemyslaw-zan Feb 26, 2025
b9072f9
Fixed z-index.
przemyslaw-zan Feb 27, 2025
55aad2b
Merge branch 'master' into i/17964
przemyslaw-zan Feb 27, 2025
3c7c56e
Bound css class to a variable.
przemyslaw-zan Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/ckeditor5-emoji/theme/emojipicker.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,8 @@
margin-right: -1px;
outline: solid 1px hsla(0, 0%, 100%, .5);
}

/* See: https://github.com/ckeditor/ckeditor5/issues/17964 */
div.ck.ck-balloon-panel:has( .ck.ck-emoji ) {
z-index: calc( var( --ck-z-dialog ) + 1 );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments archive uses --ck-z-panel for the z-index. Could you check if after replacing the variable it still works fine?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not work. See:

ckeditor5/packages/ckeditor5-ui/theme/globals/_zindex.css

Lines 6 to 10 in 26bf48f

:root {
--ck-z-default: 1;
--ck-z-panel: calc( var(--ck-z-default) + 999 );
--ck-z-dialog: 9999;
}

}
5 changes: 5 additions & 0 deletions packages/ckeditor5-mention/theme/mentionui.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,8 @@
flex-shrink: 0;
}
}

/* See: https://github.com/ckeditor/ckeditor5/issues/17964 */
div.ck.ck-balloon-panel:has( .ck.ck-mentions ) {
z-index: calc( var( --ck-z-dialog ) + 1 );
}