Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(clerk-js,types): Remove virtual routing option from component types #4977

Merged

Conversation

alexcarpenter
Copy link
Member

@alexcarpenter alexcarpenter commented Jan 22, 2025

Description

Virtual routing is only an internal option to be used within the modal components. This PR removes the routing option from the components public APIs to reduce any confusion.

Docs updates: clerk/clerk-docs#1943

Resolves SDKI-803

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Jan 22, 2025

🦋 Changeset detected

Latest commit: 9d09d5b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 22 packages
Name Type
@clerk/clerk-js Patch
@clerk/types Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
@clerk/astro Patch
@clerk/backend Patch
@clerk/elements Patch
@clerk/expo-passkeys Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/localizations Patch
@clerk/nextjs Patch
@clerk/nuxt Patch
@clerk/react-router Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/shared Patch
@clerk/tanstack-start Patch
@clerk/testing Patch
@clerk/themes Patch
@clerk/ui Patch
@clerk/vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 9:08pm

@alexcarpenter alexcarpenter marked this pull request as ready for review January 22, 2025 21:03
@alexcarpenter alexcarpenter changed the title refactor(clerk-js,types): Remove virtual routing option refactor(clerk-js,types): Remove virtual routing option from types Jan 22, 2025
@alexcarpenter alexcarpenter changed the title refactor(clerk-js,types): Remove virtual routing option from types refactor(clerk-js,types): Remove virtual routing option from component types Jan 22, 2025
@alexcarpenter alexcarpenter merged commit 1345cb4 into main Jan 27, 2025
29 checks passed
@alexcarpenter alexcarpenter deleted the alexcarpenter/sdki-803-drop-routing-virtual-from-types branch January 27, 2025 19:53
wobsoriano pushed a commit that referenced this pull request Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants