-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(clerk-js,types): Remove virtual routing option from component types #4977
Merged
alexcarpenter
merged 11 commits into
main
from
alexcarpenter/sdki-803-drop-routing-virtual-from-types
Jan 27, 2025
Merged
refactor(clerk-js,types): Remove virtual routing option from component types #4977
alexcarpenter
merged 11 commits into
main
from
alexcarpenter/sdki-803-drop-routing-virtual-from-types
Jan 27, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9d09d5b The changes in this PR will be included in the next version bump. This PR includes changesets to release 22 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alexcarpenter
commented
Jan 22, 2025
alexcarpenter
commented
Jan 22, 2025
alexcarpenter
commented
Jan 22, 2025
packages/react/src/components/__tests__/OrganizationProfile.test.tsx
Outdated
Show resolved
Hide resolved
packages/clerk-js/src/ui/components/UserProfile/UserProfile.tsx
Outdated
Show resolved
Hide resolved
LekoArts
reviewed
Jan 23, 2025
Co-authored-by: Lennart <[email protected]>
3 tasks
dstaley
approved these changes
Jan 24, 2025
LekoArts
approved these changes
Jan 27, 2025
4 tasks
wobsoriano
pushed a commit
that referenced
this pull request
Feb 8, 2025
…t types (#4977) Co-authored-by: Lennart <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Virtual routing is only an internal option to be used within the modal components. This PR removes the routing option from the components public APIs to reduce any confusion.
Docs updates: clerk/clerk-docs#1943
Resolves SDKI-803
Checklist
pnpm test
runs as expected.pnpm build
runs as expected.Type of change