bug fix: slides smooth scroll animation #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seems to prevent smooth scroll from functioning correctly?
seems to work better than using .slide.active?
to make sure the slides navigation is always starting at slide 0
- test: handleSlidesUpdate responds to state.slides changes - check for value of inert & aria-hidden attributes on all slides
|
Still not sure why after submitting the address search form the scroll animation goes from the first to the third slide instead of the second to the third slide, but I'm willing to live with it for now. |
clhenrick
commented
Dec 30, 2023
clhenrick
changed the title
- to avoid scrolling from first slide to third slide after the user searches their address. Fixes a side effect for bugfix for #131
clhenrick
added a commit
that referenced
this pull request
Jan 1, 2024
* master: bug fix: slides smooth scroll animation (#133) Update CHANGELOG.md Bugfix: search input on iOS (#132) Update CHANGELOG.md Improve a11y of address search form (#128) Update CHANGELOG.md Improve accessibility of home page slides (#125) Update CHANGELOG.md updated changelog Correct usage of HTML heading levels & other fixes (#124)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #125 which made the homepage's slides and slides navigation accessible also broke the smooth scroll animation that happens when navigating between slides (when a user does not have the "prefers-reduced-motion" setting enabled in their device).
This PR fixes that issue / restores the smooth scroll animation using GSAP.
Upgrades the GSAP library dependancy to version
13.12.2