Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug fix: slides smooth scroll animation #133

Merged
merged 18 commits into from
Jan 1, 2024
Merged

bug fix: slides smooth scroll animation #133

merged 18 commits into from
Jan 1, 2024

Commits on Dec 30, 2023

  1. fixed selector for slides container

    @clhenrick
    clhenrick committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    8ae2eee View commit details
    Browse the repository at this point in the history

  2. rm tabindex -1 from slides: 

    seems to prevent smooth scroll from functioning correctly?
    @clhenrick
    clhenrick committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    e943d56 View commit details
    Browse the repository at this point in the history

  3. pass html id value to gsap.to options: 

    seems to work better than using .slide.active?
    @clhenrick
    clhenrick committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    c035b7a View commit details
    Browse the repository at this point in the history

  4. scroll to active slide on init: 

    to make sure the slides navigation is always starting at slide 0
    @clhenrick
    clhenrick committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    1fea93e View commit details
    Browse the repository at this point in the history

  5. better naming for method params

    @clhenrick
    clhenrick committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    b01955a View commit details
    Browse the repository at this point in the history

  6. rm console.logs

    @clhenrick
    clhenrick committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    4621bca View commit details
    Browse the repository at this point in the history

  7. upgraded dep gsap to 3.12.2

    @clhenrick
    clhenrick committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    f0b9ea2 View commit details
    Browse the repository at this point in the history

  8. added back tabindex=-1 on slides

    @clhenrick
    clhenrick committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    68e1bf0 View commit details
    Browse the repository at this point in the history

  9. focus active slide on scroll complete

    @clhenrick
    clhenrick committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    d1807a1 View commit details
    Browse the repository at this point in the history

  10. rm redux logger in start script

    @clhenrick
    clhenrick committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    0795687 View commit details
    Browse the repository at this point in the history

  11. clean-up SlidesContainer

    @clhenrick
    clhenrick committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    029852a View commit details
    Browse the repository at this point in the history

  12. fixed tests for SlidesContainer

    @clhenrick
    clhenrick committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    976f1ed View commit details
    Browse the repository at this point in the history

  13. improved test in SlidesContainer: 

    - test: handleSlidesUpdate responds to state.slides changes
- check for value of inert & aria-hidden attributes on all slides
    @clhenrick
    clhenrick committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    4028df2 View commit details
    Browse the repository at this point in the history

  14. added test for scroll complete

    @clhenrick
    clhenrick committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    ba855fb View commit details
    Browse the repository at this point in the history

  15. improved test "checks prefers-reduced-motion media query"

    @clhenrick
    clhenrick committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    85d699b View commit details
    Browse the repository at this point in the history

Commits on Dec 31, 2023

  1. use gsap.fromTo for slide scroll 

    - to avoid scrolling from first slide to third slide after
  the user searches their address. Fixes a side effect for
  bugfix for #131
    @clhenrick
    clhenrick committed Dec 31, 2023
    Configuration menu
    Copy the full SHA
    88099f3 View commit details
    Browse the repository at this point in the history

  2. fixed test for SlidesContainer.scrollToActiveSlide

    @clhenrick
    clhenrick committed Dec 31, 2023
    Configuration menu
    Copy the full SHA
    91ba893 View commit details
    Browse the repository at this point in the history

  3. cleaned up activeSlide and activeSlideIndex setters logic

    @clhenrick
    clhenrick committed Dec 31, 2023
    Configuration menu
    Copy the full SHA
    b823816 View commit details
    Browse the repository at this point in the history