Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Supporting webdriverio v9 migration 2 #2753

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

pan-kot
Copy link
Member

@pan-kot pan-kot commented Sep 23, 2024

Description

A follow-up for #2735, fixing more failures from the dry run of cloudscape-design/browser-test-tools#109

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pan-kot pan-kot requested a review from a team as a code owner September 23, 2024 15:04
@pan-kot pan-kot requested review from jperals and removed request for a team September 23, 2024 15:04
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.01%. Comparing base (591a6d7) to head (8a74e24).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2753      +/-   ##
==========================================
- Coverage   96.02%   96.01%   -0.01%     
==========================================
  Files         749      749              
  Lines       20908    20908              
  Branches     7125     6750     -375     
==========================================
- Hits        20076    20075       -1     
- Misses        824      825       +1     
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pan-kot pan-kot enabled auto-merge September 23, 2024 15:57
@pan-kot pan-kot added this pull request to the merge queue Sep 24, 2024
Merged via the queue into main with commit 9139c20 Sep 24, 2024
33 checks passed
@pan-kot pan-kot deleted the chore-webdriverio9-2 branch September 24, 2024 07:53
guptbhum pushed a commit to guptbhum/components that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants