Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add lowcode-simple-table #280

Merged
merged 4 commits into from
Sep 18, 2024
Merged

feat: add lowcode-simple-table #280

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
630846f
Update package.json
owenchen1004 Aug 13, 2024
94899d7
Merge branch 'master' into master
fengmk2 Aug 14, 2024
dc078ed
Merge branch 'cnpm:master' into master
owenchen1004 Sep 18, 2024
c1d02fb
Update package.json
owenchen1004 Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18614,6 +18614,9 @@
},
"cansin-blogdata": {
"version": "*"
},
Comment on lines 18616 to +18617
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cansin-blogdata seems unrelated to the PR changes.

The existing cansin-blogdata dependency does not appear to be directly related to the introduction of the low-code component package. Similar to the feedback on lowcode-simple-table, consider specifying a version range instead of * for cansin-blogdata to maintain consistency and avoid potential issues.

"lowcode-simple-table": {
"version": "*"
Comment on lines +18618 to +18619
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider specifying a version range for lowcode-simple-table.

Adding the lowcode-simple-table dependency aligns with the PR objective of introducing a low-code related component package. However, it's recommended to specify a version range (e.g., ^1.2.3) instead of * to avoid potential breaking changes from future releases.

}
}
}
Loading