sql: add parser support for XA transactions #129298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
nvanbenschoten
force-pushed
the
nvanbenschoten/2pcSyntax
branch
from
4f9288e to
8bbc691
Compare
nvanbenschoten
force-pushed
the
nvanbenschoten/2pcSyntax
branch
from
8bbc691 to
0b32909
Compare
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
This was referenced Aug 21, 2024
Informs cockroachdb#22329. This commit adds new syntax for `PREPARE TRANSACTION <gid>`, `COMMIT PREPARED <gid>`, and `ROLLBACK PREPARED <gid>`, for parity with Postgres support. Handling of the syntax is currently unimplemented. Release note: None
nvanbenschoten
force-pushed
the
nvanbenschoten/2pcSyntax
branch
from
0b32909 to
c66a374
Compare
rafiss
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
lgtm!
Reviewed 14 of 14 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @nvanbenschoten)
|
TFTR! bors r=rafiss |
craig bot
pushed a commit
that referenced
this pull request
Dec 12, 2024
129295: sql: add max_prepared_transactions variable r=rafiss a=nvanbenschoten Informs #22329. This commit adds the `max_prepared_transactions` session variable, returning a value of math.MaxInt32 to indicate that there is no limit on the number of prepared transactions that can be created. This change has the effect of unblocking the pgjdbc `XADataSourceTest` test suite, which was previously failing during initialization. Is also includes a small patch to work around #31632 (unsupported deferrable qualifier) so that each test in the XA test suite actually runs (and fails, for the most part). Release note: None 129298: sql: add parser support for XA transactions r=rafiss a=nvanbenschoten Informs #22329. This commit adds new syntax for `PREPARE TRANSACTION <gid>`, `COMMIT PREPARED <gid>`, and `ROLLBACK PREPARED <gid>`, for parity with Postgres support. Handling of the syntax is currently unimplemented. Release note: None Co-authored-by: Nathan VanBenschoten <[email protected]>
|
Build failed (retrying...): |
craig bot
pushed a commit
that referenced
this pull request
Dec 12, 2024
129298: sql: add parser support for XA transactions r=rafiss a=nvanbenschoten Informs #22329. This commit adds new syntax for `PREPARE TRANSACTION <gid>`, `COMMIT PREPARED <gid>`, and `ROLLBACK PREPARED <gid>`, for parity with Postgres support. Handling of the syntax is currently unimplemented. Release note: None Co-authored-by: Nathan VanBenschoten <[email protected]>
|
Build failed: |
|
bors retry |
craig bot
pushed a commit
that referenced
this pull request
Dec 12, 2024
129295: sql: add max_prepared_transactions variable r=rafiss a=nvanbenschoten Informs #22329. This commit adds the `max_prepared_transactions` session variable, returning a value of math.MaxInt32 to indicate that there is no limit on the number of prepared transactions that can be created. This change has the effect of unblocking the pgjdbc `XADataSourceTest` test suite, which was previously failing during initialization. Is also includes a small patch to work around #31632 (unsupported deferrable qualifier) so that each test in the XA test suite actually runs (and fails, for the most part). Release note: None 129297: sql: create system.prepared_transactions table r=rafiss a=nvanbenschoten Informs #22329. This commit adds a new `system.prepared_transactions` table, which will be used to track prepared transactions. The table includes all of the information needed to implement XA two-phase commit transactions, along with additional metadata needed to implement `pg_catalog.pg_prepared_xacts`. Release note: None 129298: sql: add parser support for XA transactions r=rafiss a=nvanbenschoten Informs #22329. This commit adds new syntax for `PREPARE TRANSACTION <gid>`, `COMMIT PREPARED <gid>`, and `ROLLBACK PREPARED <gid>`, for parity with Postgres support. Handling of the syntax is currently unimplemented. Release note: None Co-authored-by: Nathan VanBenschoten <[email protected]>
|
Build failed (retrying...): |
craig bot
pushed a commit
that referenced
this pull request
Dec 12, 2024
129297: sql: create system.prepared_transactions table r=rafiss a=nvanbenschoten Informs #22329. This commit adds a new `system.prepared_transactions` table, which will be used to track prepared transactions. The table includes all of the information needed to implement XA two-phase commit transactions, along with additional metadata needed to implement `pg_catalog.pg_prepared_xacts`. Release note: None 129298: sql: add parser support for XA transactions r=rafiss a=nvanbenschoten Informs #22329. This commit adds new syntax for `PREPARE TRANSACTION <gid>`, `COMMIT PREPARED <gid>`, and `ROLLBACK PREPARED <gid>`, for parity with Postgres support. Handling of the syntax is currently unimplemented. Release note: None Co-authored-by: Nathan VanBenschoten <[email protected]>
|
Build failed (retrying...): |
craig bot
pushed a commit
that referenced
this pull request
Dec 12, 2024
129298: sql: add parser support for XA transactions r=rafiss a=nvanbenschoten Informs #22329. This commit adds new syntax for `PREPARE TRANSACTION <gid>`, `COMMIT PREPARED <gid>`, and `ROLLBACK PREPARED <gid>`, for parity with Postgres support. Handling of the syntax is currently unimplemented. Release note: None Co-authored-by: Nathan VanBenschoten <[email protected]>
|
Build failed: |
|
EngFlow issues this morning. bors retry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Informs #22329.
This commit adds new syntax for
PREPARE TRANSACTION <gid>,COMMIT PREPARED <gid>, andROLLBACK PREPARED <gid>, for parity with Postgres support.Handling of the syntax is currently unimplemented.
Release note: None