Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docgen: update BEGIN and SET TRANSACTION diagrams without iso level #137368

Conversation

taroface
Copy link
Collaborator

Updated the BEGIN diagram for v23.1, which had been empty since this commit. (#137058 covers v23.2 and later.)

image

Also updated the SET TRANSACTION diagram, which had not been displaying most of its syntax.

image

Epic: none
Release note: none
Release justification: non-production code change

@taroface taroface added the backport-23.1.x Flags PRs that need to be backported to 23.1 label Dec 12, 2024
@taroface taroface requested a review from a team as a code owner December 12, 2024 23:28
Copy link

blathers-crl bot commented Dec 12, 2024

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

It looks like your PR touches SQL parser code but doesn't add or edit parser tests. Please make sure you add or edit parser tests if you edit the parser.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@taroface
Copy link
Collaborator Author

blathers backport 23.1

Copy link

blathers-crl bot commented Dec 12, 2024

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 4ed4c5c to blathers/backport-release-23.1-137368: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.1 failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@taroface
Copy link
Collaborator Author

Closing as this was opened to create #137371

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants