dev: remove --strip=never configuration from .bazelrc.user
#137804
+0
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rickystewart
added
the
backport-24.3.x
Previously we unconditionally disabled stripping; however, this has a negative impact on performance (linking gets much more expensive when you do not strip). This is a cost we paid both locally in the development cycle as well as in CI. Removing this line from `.bazelrc` restores the default behavior of stripping iff the `compilation_mode` is `fastbuild` (which is the default). This will give developers the desired quick iteration behavior. You now have to opt into disabling stripping. Going forward we may evaluate if it is worth it to disable stripping for unit tests in CI to enable the use of `side-eye` (cockroachdb#136839). Until that point, there is no reason to disable stripping in this context. Stripping can be enabled with `--strip=always` or by passing `-c dbg` or `-c opt`. Notably, `dev build --cross`, the release process, and the `roachtest` nightlies all currently use `-c opt` when building, so there is nothing else to be done in these cases: they are all correctly not stripping. Epic: CRDB-17171 Release note: None
rickystewart
force-pushed
the
strip-never-2
branch
from
ac3081e to
e955be7
Compare
rail
approved these changes
Dec 19, 2024
RaduBerinde
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we unconditionally disabled stripping; however, this has a negative impact on performance (linking gets much more expensive when you do not strip). This is a cost we paid both locally in the development cycle as well as in CI.
Removing this line from
.bazelrcrestores the default behavior of stripping iff thecompilation_modeisfastbuild(which is the default). This will give developers the desired quick iteration behavior. You now have to opt into disabling stripping.Going forward we may evaluate if it is worth it to disable stripping for unit tests in CI to enable the use of
side-eye(#136839). Until that point, there is no reason to disable stripping in this context.Stripping can be enabled with
--strip=alwaysor by passing-c dbgor-c opt. Notably,dev build --cross, the release process, and theroachtestnightlies all currently use-c optwhen building, so there is nothing else to be done in these cases: they are all correctly not stripping.Epic: CRDB-17171
Release note: None