Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactored builtin-pipeline #17860

Merged
merged 11 commits into from
Nov 15, 2024
Merged

refactored builtin-pipeline #17860

merged 11 commits into from
Nov 15, 2024

Conversation

star-e
Copy link
Contributor

@star-e star-e commented Nov 14, 2024

Refactored builtin-pipeline and added PipelinePass components.


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@star-e
Copy link
Contributor Author

star-e commented Nov 14, 2024

@cocos-robot run test cases

@star-e
Copy link
Contributor Author

star-e commented Nov 14, 2024

@cocos-robot run test cases

Copy link

github-actions bot commented Nov 14, 2024

✅ Package size is not changed

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -37122,11 +37122,8 @@
         }
         export interface PipelinePassBuilder {
             getConfigOrder(): number;
             getRenderOrder(): number;
-            resetCamera?(cameraConfigs: {
-                [name: string]: any;
-            }): void;
             configCamera?(camera: Readonly<renderer.scene.Camera>, pplConfigs: {
                 readonly [name: string]: any;
             }, cameraConfigs: {
                 [name: string]: any;

Copy link

@star-e, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS FAIL shield-node
ios PASS PASS FAIL shield-node
mac PASS PASS FAIL shield-node

Copy link

@star-e, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
windows PASS PASS FAIL shield-node
android PASS PASS FAIL shield-node
wechatgame PASS PASS FAIL shield-node

Copy link

@star-e, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS FAIL shield-node
ios PASS PASS FAIL shield-node
mac PASS PASS FAIL shield-node

Copy link

@star-e, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
windows PASS PASS FAIL shield-node
android PASS PASS FAIL shield-node
wechatgame PASS PASS FAIL shield-node

@star-e star-e requested review from minggo and GengineJS November 15, 2024 01:48
@star-e star-e requested a review from dumganhar November 15, 2024 02:11
@@ -137,1295 +123,1656 @@ function setupPipelineConfigs(
configs.platform.w = (screenSpaceSignY * 0.5 + 0.5) << 1 | (device.capabilities.clipSpaceSignY * 0.5 + 0.5);
}

export interface PipelineSettings2 extends PipelineSettings {
_passes?: rendering.PipelinePassBuilder[];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will _passes be designed as a private property?
I found that all properties in PipelineSettings do not have a _ prefix.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_passes is not enumerable. It is used in runtime and will not be serialized.

@star-e
Copy link
Contributor Author

star-e commented Nov 15, 2024

@cocos-robot run test cases

@star-e star-e merged commit bbb96cf into cocos:v3.8.5 Nov 15, 2024
12 checks passed
@star-e star-e deleted the v3.8.5-pipeline branch November 15, 2024 05:16
qiuguohua pushed a commit to qiuguohua/cocos-engine that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants