-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactored builtin-pipeline #17860
refactored builtin-pipeline #17860
Conversation
@cocos-robot run test cases |
@cocos-robot run test cases |
✅ Package size is not changedInterface Check Report! WARNING this pull request has changed these public interfaces:
@@ -37122,11 +37122,8 @@
}
export interface PipelinePassBuilder {
getConfigOrder(): number;
getRenderOrder(): number;
- resetCamera?(cameraConfigs: {
- [name: string]: any;
- }): void;
configCamera?(camera: Readonly<renderer.scene.Camera>, pplConfigs: {
readonly [name: string]: any;
}, cameraConfigs: {
[name: string]: any;
|
@star-e, Please check the result of
Task Details
|
@star-e, Please check the result of
Task Details
|
@star-e, Please check the result of
Task Details
|
@star-e, Please check the result of
Task Details
|
@@ -137,1295 +123,1656 @@ function setupPipelineConfigs( | |||
configs.platform.w = (screenSpaceSignY * 0.5 + 0.5) << 1 | (device.capabilities.clipSpaceSignY * 0.5 + 0.5); | |||
} | |||
|
|||
export interface PipelineSettings2 extends PipelineSettings { | |||
_passes?: rendering.PipelinePassBuilder[]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will _passes
be designed as a private property?
I found that all properties in PipelineSettings do not have a _
prefix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_passes
is not enumerable. It is used in runtime and will not be serialized.
@cocos-robot run test cases |
Refactored builtin-pipeline and added
PipelinePass
components.Continuous Integration
This pull request:
Compatibility Check
This pull request: