Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3.8.5] Fix light probe could not work. Revert a change in vec3.ts #17999

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

dumganhar
Copy link
Contributor

@dumganhar dumganhar commented Dec 3, 2024

It's a bug starts from v3.8.5 branch: #17703

Code in 3.8.4: https://github.com/cocos/cocos-engine/blob/3.8.4/cocos/core/math/vec3.ts#L949

Re: https://github.com/cocos/3d-tasks/issues/18617#event-15503908587

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

It's a bug starts from v3.8.5 branch: cocos#17703
@dumganhar dumganhar changed the title [v3.8.5] Fix light probe could not work. [v3.8.5] Fix light probe could not work. Revert a change in vec3.ts Dec 3, 2024
Copy link

github-actions bot commented Dec 3, 2024

⚠️ Package size ⤴ 37 bytes, old: 5441124, new: 5441161

Interface Check Report

This pull request does not change any public interfaces !

@dumganhar dumganhar merged commit b4a5a7c into cocos:v3.8.5 Dec 3, 2024
13 checks passed
@dumganhar
Copy link
Contributor Author

@cocos-robot run test cases

Copy link

github-actions bot commented Dec 3, 2024

@dumganhar, Please check the result of run test cases:

Task Details

Copy link

github-actions bot commented Dec 3, 2024

@dumganhar, Please check the result of run test cases:

Task Details

@bofeng-song
Copy link
Contributor

https://github.com/cocos/3d-tasks/issues/18655
用了最新代码后,该issue也不会黑屏了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants