Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3.8.5] Fix light probe could not work. Revert a change in vec3.ts #17999

Merged
merged 1 commit into from
Dec 3, 2024
+5 −1
Merged

[v3.8.5] Fix light probe could not work. Revert a change in vec3.ts #17999

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion cocos/core/math/vec3.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -955,7 +955,11 @@ export class Vec3 extends ValueType {
* @returns Returns `true` when the components of both vectors are equal within the specified range of error; otherwise it returns `false`.
*/
public equals (other: Vec3, epsilon = EPSILON): boolean {
return Vec3.equals(this, other, epsilon);
return (
abs(this.x - other.x) <= epsilon
&& abs(this.y - other.y) <= epsilon
&& abs(this.z - other.z) <= epsilon
);
}

/**
Expand Down
Loading