Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete account view #461

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Delete account view #461

wants to merge 5 commits into from

Conversation

mmircea16
Copy link
Contributor

Closing #419

Couldn't test locally the integration with with the backend due to CORS issues.

@vercel
Copy link

vercel bot commented Jun 27, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/code4romania/stam-acasa/mvqaiho9q
✅ Preview: https://stam-acasa-git-delete-account.code4romania.vercel.app

@RaduCStefanescu RaduCStefanescu requested a review from Utwo June 27, 2020 15:25
surdu
surdu requested changes Jun 27, 2020
View reviewed changes
frontend/src/components/DeleteAccount/index.js Outdated Show resolved Hide resolved
frontend/src/api/accountApi.js

const AccountApi = {
deleteAccount: (user, password) =>
api.post("/DeleteAccount", { Username: user, Password: password })
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we pass the user and not taking it from the session ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point! Had a chat with @RaduCStefanescu and my takeaway was we need to ask for them to type the email and password. It might be that I got it wrong and we only need to ask for the password. @RaduCStefanescu can you clarify if there is a requirement to ask the user to put in the email?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on this comment I'm guessing he's on-board with the idea 😁

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool! I will update the PR accordingly

@surdu surdu mentioned this pull request Jul 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surdu surdu surdu approved these changes

@RaduCStefanescu RaduCStefanescu RaduCStefanescu left review comments

@bvizureanu bvizureanu Awaiting requested review from bvizureanu bvizureanu is a code owner

@Utwo Utwo Awaiting requested review from Utwo

Assignees
No one assigned
Labels
front-end
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmircea16 @surdu @RaduCStefanescu