fix(questionnaire): directors can update questionnaires with invalid information #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
directors can now update questionnaires with missing country or agreements fields. This is done a temp fix for bh7 but should be removed later
houndci-bot
reviewed
Feb 11, 2021
cbaudouinjr
requested changes
Feb 14, 2021
houndci-bot
reviewed
Feb 14, 2021
JeremyRudman
changed the title
peterkos
reviewed
Feb 15, 2021
| = u.input :last_name, label: "Last Name" | ||
| = f.input :email, input_html: { value: @questionnaire.user.try(:email) }, required: true, hint: 'Can be an existing user (without a questionnaire) or a new user. If this is a new user, they will receive a randomly-generated password that they must request a password reset for.' | ||
| = f.input :phone | ||
| = f.input :date_of_birth, start_year: Date.today.year - 18, end_year: Date.today.year - 90, order: [:month, :day, :year] |
There was a problem hiding this comment.
What's the - 18 and - 90 logic? Checking for minor?
We should refactor this logic for validation in 3.0
There was a problem hiding this comment.
that set the start year and the end year in the drop down to 1931 and 2003. I assume that is meant as basic minor checking but it is set as -5 for the user facing application so I will set it to that here as well
|
Niche feature with potential downsides downsides so this is being sidelined |
|
Closing in favor of 3.0 work; written down in Notion to go back to! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a option to disable validation for when directors submit questionnaires
