fix(questionnaire): directors can update questionnaires with invalid information

app/assets/javascripts/manage/lib/forms.js

@@ -32,3 +32,11 @@ var setupManageForms = function() {
     updateMessageForm();
   });
 };
+
+document.addEventListener('turbolinks:load', function () {
+  $('#validateFormSwitch').val($('#validateSwitch').is(':checked'));
+  $('#validateSwitch').on('change', function () {
+    $('#validateFormSwitch').val($('#validateSwitch').is(':checked'));
+  })
+});
+

app/controllers/manage/questionnaires_controller.rb

@@ -61,7 +61,11 @@ def update
     @questionnaire.user.update_attributes(email: email) if email.present?
     update_params = convert_school_name_to_id(update_params)
     update_params = convert_boarded_bus_param(update_params, @questionnaire)
-    @questionnaire.update_attributes(update_params)
+    if update_params[:validate_switch] == 'false'
+      @questionnaire.update_with_invalid_attributes(update_params)
+    else
+      @questionnaire.update_attributes(update_params)
+    end
     respond_with(:manage, @questionnaire)
   end
 
@@ -157,7 +161,7 @@ def questionnaire_params
       :portfolio_url, :vcs_url, :bus_captain_interest, :phone, :can_share_info,
       :travel_not_from_school, :travel_location,
       :graduation_year, :race_ethnicity, :resume, :delete_resume, :why_attend,
-      :bus_list_id, :is_bus_captain, :boarded_bus
+      :bus_list_id, :is_bus_captain, :boarded_bus, :country, :validate_switch
     )
   end
 

app/models/questionnaire.rb

@@ -1,6 +1,8 @@
 class Questionnaire < ApplicationRecord
   audited
 
+  attr_accessor :validate_switch
+
   include ActiveModel::Dirty
   include DeletableAttachment
   before_validation :consolidate_school_names
@@ -430,6 +432,11 @@ def unaccepted_agreements
     Agreement.all - agreements
   end
 
+  def update_with_invalid_attributes(attributes)
+    assign_attributes(attributes)
+    save!(validate: false)
+  end
+
   def as_json(options = {})
     result = super
     result['all_agreements_accepted'] = all_agreements_accepted?

app/views/manage/questionnaires/_form.html.haml

@@ -13,24 +13,24 @@
               %h6.card-subtitle.mb-2
                 %span.badge.badge-info Provided by MyMLH
             = f.simple_fields_for :user, @questionnaire.user do |u|
-              = u.input :first_name, input_html: { "data-validate" => "presence" }, label: "First Name", autofocus: true
-              = u.input :last_name, input_html: { "data-validate" => "presence" }, label: "Last Name"
-            = f.input :email, input_html: { "data-validate" => "presence email", value: @questionnaire.user.try(:email) }, required: true, hint: 'Can be an existing user (without a questionnaire) or a new user. If this is a new user, they will receive a randomly-generated password that they must request a password reset for.'
-            = f.input :phone, input_html: { "data-validate" => "presence" }
-            = f.input :date_of_birth, start_year: Date.today.year - 18, end_year: Date.today.year - 90, order: [:month, :day, :year], input_html: { "data-validate" => "presence" }
-            = f.input :school_id, as: :school_selection, input_html: { "data-validate" => "presence" }
-            = f.input :level_of_study, input_html: { "data-validate" => "presence" }
-            = f.input :major, input_html: { "data-validate" => "presence" }
-            = f.input :gender, input_html: { "data-validate" => "presence" }
-            = f.input :country, as: :select, collection: Questionnaire::POSSIBLE_COUNTRIES, include_blank: "(select one...)", input_html: { "data-validate" => "presence" }
+              = u.input :first_name, label: "First Name", autofocus: true
+              = u.input :last_name, label: "Last Name"
+            = f.input :email, input_html: { value: @questionnaire.user.try(:email) }, required: true, hint: 'Can be an existing user (without a questionnaire) or a new user. If this is a new user, they will receive a randomly-generated password that they must request a password reset for.'
+            = f.input :phone
+            = f.input :date_of_birth, start_year: Date.today.year - 18, end_year: Date.today.year - 90, order: [:month, :day, :year]
+            = f.input :school_id, as: :school_selection
+            = f.input :level_of_study
+            = f.input :major
+            = f.input :gender
+            = f.input :country, as: :select, collection: Questionnaire::POSSIBLE_COUNTRIES, include_blank: "(select one...)"
 
         - if !HackathonConfig['digital_hackathon']
           .card.mb-4
             .card-header Travel information
             .card-body
               - travel_state = [email protected]_record? && @questionnaire.travel_not_from_school
               = f.input :travel_not_from_school, label: "I will not be traveling from my school"
-              = f.input :travel_location, input_html: { "data-validate" => "presence", disabled: !travel_state }, wrapper_html: { style: travel_state ? "" : "display: none" }, label: "Travel Location"
+              = f.input :travel_location, input_html: { disabled: !travel_state }, wrapper_html: { style: travel_state ? "" : "display: none" }, label: "Travel Location"
 
               = f.association :bus_list, label: "Bus list", include_blank: 'Not travelling on a sponsored bus'
               = f.input :boarded_bus, as: :boolean, label: "Boarded bus", input_html: { checked: @questionnaire.boarded_bus_at.present? }
@@ -40,7 +40,7 @@
         .card.mb-4
           .card-header Special notices
           .card-body
-            = f.input :shirt_size, as: :select, collection: Questionnaire::POSSIBLE_SHIRT_SIZES, include_blank: "(select one...)", input_html: { "data-validate" => "presence" }
+            = f.input :shirt_size, as: :select, collection: Questionnaire::POSSIBLE_SHIRT_SIZES, include_blank: "(select one...)"
             - if !HackathonConfig['digital_hackathon']
               = f.input :dietary_restrictions, label: "Dietary restrictions"
             = f.input :special_needs, label: "Special needs"
@@ -50,11 +50,11 @@
             - if HackathonManager.field_enabled?(:why_attend)
               = f.input :why_attend, label: "Why #{HackathonConfig['name']}?", placeholder: "In a sentence or two, why would you like to attend #{HackathonConfig['name']}?", input_html: { rows: 3, maxlength: 280 }
 
-            = f.input :experience, as: :select, collection: Questionnaire::POSSIBLE_EXPERIENCES.invert, include_blank: "(select one...)", label: "Experience", input_html: { "data-validate" => "presence" }
-            = f.input :interest, as: :select, collection: Questionnaire::POSSIBLE_INTERESTS.invert, include_blank: "(select one...)", label: "Interest", input_html: { "data-validate" => "presence" }
+            = f.input :experience, as: :select, collection: Questionnaire::POSSIBLE_EXPERIENCES.invert, include_blank: "(select one...)", label: "Experience"
+            = f.input :interest, as: :select, collection: Questionnaire::POSSIBLE_INTERESTS.invert, include_blank: "(select one...)", label: "Interest"
 
-            = f.input :graduation_year, as: :select, collection: Questionnaire::POSSIBLE_GRAD_YEARS, include_blank: "(select one...)", label: "Graduation year", input_html: { "data-validate" => "presence" }, wrapper_html: { class: 'input--half' }
-            = f.input :race_ethnicity, as: :select, collection: Questionnaire::POSSIBLE_RACE_ETHNICITIES, include_blank: "(select one...)", label: "Race/Ethnicity", input_html: { "data-validate" => "presence" }, wrapper_html: { class: 'input--half' }
+            = f.input :graduation_year, as: :select, collection: Questionnaire::POSSIBLE_GRAD_YEARS, include_blank: "(select one...)", label: "Graduation year", wrapper_html: { class: 'input--half' }
+            = f.input :race_ethnicity, as: :select, collection: Questionnaire::POSSIBLE_RACE_ETHNICITIES, include_blank: "(select one...)", label: "Race/Ethnicity", wrapper_html: { class: 'input--half' }
 
             = f.input :resume, as: :deletable_attachment, hint: "Must be under 2MB", input_html: { "data-validate" => "file-max-size file-content-type", "data-validate-file-max-size" => "2097152", "data-validate-file-content-type" => "application/pdf" }, label: "Resume (PDF)"
 
@@ -64,4 +64,8 @@
             = f.input :can_share_info, label: "Share resume with employers?"
 
     .center.mb-4
+      .custom-control.custom-switch.pb-3
+        = f.input :validate_switch, as: :hidden, input_html: { id: "validateFormSwitch" }
+        %input.custom-control-input{ type: "checkbox", id: "validateSwitch", checked: true }
+        %label.custom-control-label{ for: "validateSwitch" } Enable Validation
       = f.button :submit, value: ( @questionnaire.new_record? ? 'Create' : 'Save' ), class: 'btn-primary'