FYST 754 implement form 502 xml pdf two income subtraction #5012
Conversation
|
Heroku app: https://gyr-review-app-5012-75395960f220.herokuapp.com/ |
app/lib/efile/md/md502_calculator.rb
Outdated
| # MD502SU Subtractions | ||
| @md502_su.calculate | ||
| set_line(:MD502_LINE_13, :calculate_line_13) |
There was a problem hiding this comment.
These lines were moved lower, not deleted
spec/fixtures/state_file/fed_return_jsons/2023/md/todd_and_spouse_1099_int.json
Outdated
Show resolved
Hide resolved
| if primary_or_spouse == :primary | ||
| @lines[:MD_TWO_INCOME_WK_LINE_1_A].value + | ||
| @lines[:MD_TWO_INCOME_WK_LINE_2_A].value | ||
| else | ||
| @lines[:MD_TWO_INCOME_WK_LINE_1_B].value + | ||
| @lines[:MD_TWO_INCOME_WK_LINE_2_B].value | ||
| end |
There was a problem hiding this comment.
filer = primary_or_spouse == :primary ? "A" : "B"
line_or_zero("MD_TWO_INCOME_WK_LINE_1_#{filer}") +
line_or_zero("MD_TWO_INCOME_WK_LINE_2_{filer}")
we spoke during our pairing/review session about changing this method to look something like this in order to make it more clear that the calculations are very similar.
i think it is more clear this way, but i will also leave it up to you since it feels more stylistic & either implementation is fine.
| end | ||
| end | ||
| end | ||
|
|
||
| describe "#calculate_line_15" do | ||
| before do | ||
| intake.direct_file_data.total_qualifying_dependent_care_expenses = 2 |
There was a problem hiding this comment.
[dust] since we're now relying on numbers to calculate these, it could make sense to also stub the lines here as opposed to setting the values for intake.direct_file_data.total_qualifying_dependent_care_expenses and intake.direct_file_data.fed_taxable_ssb
There was a problem hiding this comment.
the update was to set the line in the calculator using those fields, but not to add the calculate_line_x methods, so the way this is set up is still correct
| end | ||
| instance.calculate | ||
|
|
||
| expect(instance.lines[:MD_TWO_INCOME_WK_LINE_1_A].value).to eq(90) |
There was a problem hiding this comment.
[dust] since we have the pattern elsewhere of adding and subtracting the values, we could do the same here as well. for example:
expect(instance.lines[:MD_TWO_INCOME_WK_LINE_1_A].value).to eq(100-10)
| } | ||
|
|
||
| # TODO: Some MFJ tests are missing spouse JSON - should not happen in prod | ||
| return 0 unless filer_json |
There was a problem hiding this comment.
more of a question than a request for change, why is it no longer an issue if there isn't a filer_json?
| @@ -119,6 +115,13 @@ def calculate_line_6 | |||
| def calculate_line_7 | |||
| @lines[:MD_TWO_INCOME_WK_LINE_6].value.clamp(0, 1_200) | |||
| end | |||
|
|
|||
| def find_filer_json_for(primary_or_spouse) | |||
There was a problem hiding this comment.
I like this extraction!
|
@mpidcock asked for a re-review since the total unemployment per filer will be provided in the json. everything looks good! i appreciate the refactor of pulling out the method for |
…df-two-income-subtraction # Conflicts: # app/lib/efile/md/md502_calculator.rb # app/models/direct_file_json_data.rb # spec/fixtures/state_file/fed_return_jsons/md/minimal_with_spouse.json # spec/fixtures/state_file/fed_return_xmls/md/minimal_with_spouse.xml # spec/lib/submission_builder/ty2024/states/md/md_return_xml_spec.rb
…df-two-income-subtraction
mpidcock
force-pushed
the
FYST-754-implement-form-502-xml-pdf-two-income-subtraction
branch
3 times, most recently
from
d6915ac
to
0e8e83e
Compare
mpidcock
force-pushed
the
FYST-754-implement-form-502-xml-pdf-two-income-subtraction
branch
from
0e8e83e
to
0fa7f68
Compare
…df-two-income-subtraction # Conflicts: # app/lib/submission_builder/ty2024/states/md/documents/md502.rb
mpidcock
deleted the
FYST-754-implement-form-502-xml-pdf-two-income-subtraction
branch
Link to pivotal/JIRA issue
Is PM acceptance required? (delete one)
Reminder: merge main into this branch and get green tests before merging to main
What was done?
How to test?
Screenshots (for visual changes)