Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FYST 754 implement form 502 xml pdf two income subtraction #5012

Merged
merged 33 commits into from
Nov 27, 2024
Merged

FYST 754 implement form 502 xml pdf two income subtraction #5012

merged 33 commits into from
Nov 27, 2024

Commits on Nov 19, 2024

  1. WIP: preliminary implementation with no income

    @mpidcock
    mpidcock committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    e975d02 View commit details
    Browse the repository at this point in the history

  2. WIP: add tests with hardcoded values for spouse and primary

    @mpidcock
    mpidcock committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    4933874 View commit details
    Browse the repository at this point in the history

  3. WIP: implement first pass at data sources for worksheet calculations

    @mpidcock
    mpidcock committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    86ed380 View commit details
    Browse the repository at this point in the history

  4. Add TwoIncome calculation to xml & pdf

    @mpidcock
    mpidcock committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    3a1986f View commit details
    Browse the repository at this point in the history

  5. WIP add labels and minor fixes

    @mpidcock
    mpidcock committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    4d07b8f View commit details
    Browse the repository at this point in the history

  6. WIP #calculate_fed_income base case tests passing

    @mpidcock
    mpidcock committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    522da0d View commit details
    Browse the repository at this point in the history

  7. WIP #calculate_fed_income base case tests passing

    @mpidcock
    mpidcock committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    8cfc8f8 View commit details
    Browse the repository at this point in the history

  8. WIP test #calculate_fed_subtractions

    @mpidcock
    mpidcock committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    14c32c8 View commit details
    Browse the repository at this point in the history

  9. WIP test #calculate_line_2

    @mpidcock
    mpidcock committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    7299cf1 View commit details
    Browse the repository at this point in the history

  10. WIP test #calculate_line_4

    @mpidcock
    mpidcock committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    187af36 View commit details
    Browse the repository at this point in the history

  11. WIP test #calculate_line_2

    @mpidcock
    mpidcock committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    e355e92 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. WIP test math calculations

    @mpidcock
    mpidcock committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    b4809e1 View commit details
    Browse the repository at this point in the history

  2. WIP handle nil and non-MFJ

    @mpidcock
    mpidcock committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    aee0d99 View commit details
    Browse the repository at this point in the history

  3. WIP add some missing federal info editor fields

    @mpidcock
    mpidcock committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    4e85dfc View commit details
    Browse the repository at this point in the history

  4. WIP fix tests

    @mpidcock
    mpidcock committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    ecef327 View commit details
    Browse the repository at this point in the history

  5. WIP update MFJ/MFS ssns to match new trait

    @mpidcock
    mpidcock committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    b3b5768 View commit details
    Browse the repository at this point in the history

  6. WIP nil safety and cosmetics

    @mpidcock
    mpidcock committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    18d1df9 View commit details
    Browse the repository at this point in the history

  7. more tests

    @mpidcock
    mpidcock committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    f182b0e View commit details
    Browse the repository at this point in the history

  8. add line 14 to line 15 calculations

    @mpidcock
    mpidcock committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    cd9fe69 View commit details
    Browse the repository at this point in the history

  9. update subtractions to use caluclation methods

    @mpidcock
    mpidcock committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    ac5b37c View commit details
    Browse the repository at this point in the history

  10. code review feedback

    @mpidcock
    mpidcock committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    a36b52a View commit details
    Browse the repository at this point in the history

  11. add labels

    @mpidcock
    mpidcock committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    8253798 View commit details
    Browse the repository at this point in the history

  12. don't use setter for interest_reports

    @mpidcock
    mpidcock committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    272f350 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. cleanup

    @mpidcock
    mpidcock committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    aa027e7 View commit details
    Browse the repository at this point in the history

  2. add line 14 test

    @mpidcock
    mpidcock committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    3ef8915 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2024

  1. code review feedback

    @mpidcock
    mpidcock committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    2b92f3d View commit details
    Browse the repository at this point in the history

  2. use json for 1099G info instead

    @mpidcock
    mpidcock committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    43a352c View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. Merge branch 'refs/heads/main' into FYST-754-implement-form-502-xml-p… 

    …df-two-income-subtraction

# Conflicts:
#	app/lib/efile/md/md502_calculator.rb
#	app/models/direct_file_json_data.rb
#	spec/fixtures/state_file/fed_return_jsons/md/minimal_with_spouse.json
#	spec/fixtures/state_file/fed_return_xmls/md/minimal_with_spouse.xml
#	spec/lib/submission_builder/ty2024/states/md/md_return_xml_spec.rb
    @mpidcock
    mpidcock committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    c7dcf70 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2024

  1. Merge branch 'refs/heads/main' into FYST-754-implement-form-502-xml-p… 

    …df-two-income-subtraction
    @mpidcock
    mpidcock committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    6600cc4 View commit details
    Browse the repository at this point in the history

  2. add acceptance testing scenarios

    @mpidcock
    mpidcock committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    0fa7f68 View commit details
    Browse the repository at this point in the history

  3. fix scenario 9 w2

    @mpidcock
    mpidcock committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    1be6233 View commit details
    Browse the repository at this point in the history

  4. Remove acceptance testing scenarios

    @mpidcock
    mpidcock committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    1f854ae View commit details
    Browse the repository at this point in the history

  5. Merge branch 'refs/heads/main' into FYST-754-implement-form-502-xml-p… 

    …df-two-income-subtraction

# Conflicts:
#	app/lib/submission_builder/ty2024/states/md/documents/md502.rb
    @mpidcock
    mpidcock committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    28ff738 View commit details
    Browse the repository at this point in the history