fix: check conflicts with Space name for complaintUsername #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xcoulon
approved these changes
Sep 22, 2023
Co-authored-by: Xavier Coulon <[email protected]>
Co-authored-by: Rajiv Senthilnathan <[email protected]>
|
/retest |
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #867 +/- ##
==========================================
+ Coverage 83.48% 83.50% +0.01%
==========================================
Files 52 52
Lines 5869 5880 +11
==========================================
+ Hits 4900 4910 +10
- Misses 791 792 +1
Partials 178 178
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexeykazakov, MatousJobanek, rajivnathan, xcoulon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/SANDBOX-369
This should help us to workaround the issue when users cannot reactivate because of having Space stuck in a terminating state https://redhat-internal.slack.com/archives/CHK0J6HT6/p1695253339361769
paired with: codeready-toolchain/toolchain-e2e#798