-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
verify that conflicts with Space names are being checked for compliantUsername #798
verify that conflicts with Space names are being checked for compliantUsername #798
Conversation
|
||
// then | ||
compliantUsername := userSignup.Status.CompliantUsername | ||
require.Equal(s.T(), fmt.Sprintf("%s-2", conflictingSpace.Name), compliantUsername) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit lost: why is the usersignup's CompliantUserName
already set to something like conflicting-2
at the beginning of the test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
look at the // given
part - it creates a Space with "conflicting" name there.
/retest |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexeykazakov, MatousJobanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
paired with codeready-toolchain/host-operator#867