Do not use the now removed CapacityThresholds in the tests and the utility methods. #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metlos
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19,
sbryzak and
mfrancisc
as code owners
This was referenced Mar 26, 2024
Merged
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #379 +/- ##
=======================================
Coverage 77.98% 77.98%
=======================================
Files 47 47
Lines 1958 1958
=======================================
Hits 1527 1527
Misses 373 373
Partials 58 58 |
rajivnathan
approved these changes
Apr 8, 2024
…onfig-capacity-thresholds
This can now be merged to master.
|
|
Since the CI jobs seem to be stuck (even though the GitHub Actions outage that was going on in the recent hours seems to have been resolved), I will just close this PR and open a new one from the same branch 🤞🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been superseded by #389.
This updates the tests to not use the
CapacityThresholdsin theToolchainConfig, because those fields are being removed in the associatedapiPR (codeready-toolchain/api#411).Additionally, test utility methods for the
CapacityThresholdsare also removed.See https://issues.redhat.com/browse/KUBESAW-36.
Associated PRs:
- host-operator: codeready-toolchain/host-operator#1000
- toolchain-e2e: codeready-toolchain/toolchain-e2e#935
- api: codeready-toolchain/api#411