Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the latest version of toolchain-common and api #935

Conversation

metlos
Copy link
Contributor

@metlos metlos commented Mar 26, 2024

Update to the latest version of toolchain-common and api to make sure the tests still work with the removed CapacityThresholds from ToolchainConfig.

See https://issues.redhat.com/browse/KUBESAW-36.

Associated PRs:
- toolchain-common: codeready-toolchain/toolchain-common#379
- host-operator: codeready-toolchain/host-operator#1000
- api: codeready-toolchain/api#411

the tests still work with the removed CapacityThresholds from ToolchainConfig.
Copy link
Collaborator

@MatousJobanek MatousJobanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

…onfig-capacity-thresholds

# Conflicts:
#	go.sumd
Copy link

openshift-ci bot commented Apr 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, MatousJobanek, metlos, rajivnathan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MatousJobanek,alexeykazakov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rsoaresd
Copy link
Contributor

Hello @metlos,

The last run failed while waiting for host-operator-controller-manager to be ready. In the logs, I found this:

{"level":"error","ts":"2024-04-24T07:51:15.869Z","msg":"host operator deployment is not ready","controller":"toolchainstatus","controllerGroup":"toolchain.dev.openshift.com","controllerKind":"ToolchainStatus","ToolchainStatus":{"name":"toolchain-status","namespace":"toolchain-host-24074852"},"namespace":"toolchain-host-24074852","name":"toolchain-status","reconcileID":"179ddb61-9c17-4eb6-9b80-f6b271809540","error":"deployment has unready status conditions: Available","stacktrace":"github.com/codeready-toolchain/host-operator/controllers/toolchainstatus.(*Reconciler).hostOperatorHandleStatus\n\t/home/runner/work/host-operator/host-operator/controllers/toolchainstatus/toolchainstatus_controller.go:314\ngithub.com/codeready-toolchain/host-operator/controllers/toolchainstatus.(*Reconciler).aggregateAndUpdateStatus\n\t/home/runner/work/host-operator/host-operator/controllers/toolchainstatus/toolchainstatus_controller.go:197\ngithub.com/codeready-toolchain/host-operator/controllers/toolchainstatus.(*Reconciler).Reconcile\n\t/home/runner/work/host-operator/host-operator/controllers/toolchainstatus/toolchainstatus_controller.go:156\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile\n\t/tmp/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:121\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/tmp/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:320\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/tmp/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:273\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/tmp/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:234"}

For now, I only found one occurrence, based on this search query.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
8.6% Duplication on New Code

See analysis details on SonarCloud

@metlos metlos merged commit 36150c6 into codeready-toolchain:master Apr 24, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants