Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented ReverseDirectRelationConnection #1540

Merged
merged 11 commits into from
Dec 20, 2023
Merged

Conversation

doctrino
Copy link
Contributor

@doctrino doctrino commented Dec 5, 2023

Description

Please describe the change you have made.

Checklist:

  • Tests added/updated.
  • Documentation updated. Documentation is generated from docstrings - these must be updated according to your change.
    If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.
  • Changelog updated in CHANGELOG.md.
  • Version bumped. If triggering a new release is desired, bump the version number in _version.py and pyproject.toml per semantic versioning.

@doctrino doctrino force-pushed the reverse-direct-relation branch from 92370b9 to bb8ebbc Compare December 5, 2023 05:24
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Merging #1540 (39988f2) into master (a7a1685) will increase coverage by 91.64%.
The diff coverage is 90.80%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1540       +/-   ##
===========================================
+ Coverage        0   91.64%   +91.64%     
===========================================
  Files           0      120      +120     
  Lines           0    15795    +15795     
===========================================
+ Hits            0    14476    +14476     
- Misses          0     1319     +1319     
Files Coverage Δ
cognite/client/_version.py 100.00% <100.00%> (ø)
...nite/client/data_classes/data_modeling/__init__.py 100.00% <ø> (ø)
cognite/client/data_classes/data_modeling/ids.py 91.82% <94.73%> (ø)
cognite/client/data_classes/data_modeling/views.py 95.15% <90.25%> (ø)

... and 116 files with indirect coverage changes

@doctrino doctrino marked this pull request as ready for review December 5, 2023 05:54
@doctrino doctrino requested review from a team as code owners December 5, 2023 05:54
Copy link
Collaborator

@erlendvollset erlendvollset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a small encapsulation fix. LGTM!

@erlendvollset erlendvollset force-pushed the reverse-direct-relation branch from 76fe211 to 0cc3ae2 Compare December 20, 2023 13:52
@per-tol per-tol enabled auto-merge (squash) December 20, 2023 14:07
@per-tol per-tol merged commit 487dc72 into master Dec 20, 2023
8 checks passed
@per-tol per-tol deleted the reverse-direct-relation branch December 20, 2023 14:12
@doctrino doctrino mentioned this pull request Dec 21, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants