-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented ReverseDirectRelationConnection #1540
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doctrino
force-pushed
the
reverse-direct-relation
branch
from
December 5, 2023 05:24
92370b9
to
bb8ebbc
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1540 +/- ##
===========================================
+ Coverage 0 91.64% +91.64%
===========================================
Files 0 120 +120
Lines 0 15795 +15795
===========================================
+ Hits 0 14476 +14476
- Misses 0 1319 +1319
|
doctrino
commented
Dec 5, 2023
per-tol
reviewed
Dec 11, 2023
tests/tests_unit/test_data_classes/test_data_models/test_views.py
Outdated
Show resolved
Hide resolved
tests/tests_integration/test_api/test_data_modeling/test_views.py
Outdated
Show resolved
Hide resolved
erlendvollset
approved these changes
Dec 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a small encapsulation fix. LGTM!
erlendvollset
force-pushed
the
reverse-direct-relation
branch
from
December 20, 2023 13:52
76fe211
to
0cc3ae2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please describe the change you have made.
Checklist:
If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.