-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: take CDM/v1 using typed instances to GA #1919
Conversation
35444b4
to
03c67a1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1919 +/- ##
=======================================
Coverage 89.28% 89.28%
=======================================
Files 131 131
Lines 20806 20808 +2
=======================================
+ Hits 18576 18579 +3
+ Misses 2230 2229 -1
|
What's the deal with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Main comment is to avoid manually editing the generated files, and instead update the source (pygen) template
So per now TypedNode(..).properties returns an empty dict, and TypedNodeApply().sources returns None. They’re just being resolved correctly when dumping, which is not how it should be. |
CogniteDescribableNode/CogniteSchedulableNode etc. need to be renamed. Those can be used for edges as well as nodes. |
3c67d96
to
03c67a1
Compare
@erlendvollset / @doctrino PR is reverted to not include any changes to datetime and TypedNode inheritance changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just add back the warning and then good to go.
7b61d12
to
838164b
Compare
This reverts commit c1cc353.
1c9fc77
to
8d7b5e9
Compare
Description
This PR takes CDM/v1 using typed instances to GA.
DM-2068