Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: take CDM/v1 using typed instances to GA #1919

Merged
merged 12 commits into from
Sep 16, 2024

final cleanup (extracted from reverted PR)

11b6c45
Select commit
Loading
Failed to load commit list.
Merged

WIP: take CDM/v1 using typed instances to GA #1919

final cleanup (extracted from reverted PR)
11b6c45
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 16, 2024 in 1s

89.28% (+0.00%) compared to dd79d3c

View this Pull Request on Codecov

89.28% (+0.00%) compared to dd79d3c

Details

Codecov Report

Attention: Patch coverage is 89.79592% with 5 lines in your changes missing coverage. Please review.

Project coverage is 89.28%. Comparing base (dd79d3c) to head (11b6c45).

Files with missing lines Patch % Lines
cognite/client/_api/data_modeling/instances.py 40.00% 3 Missing ⚠️
...ite/client/data_classes/data_modeling/instances.py 95.23% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1919   +/-   ##
=======================================
  Coverage   89.28%   89.28%           
=======================================
  Files         131      131           
  Lines       20806    20808    +2     
=======================================
+ Hits        18576    18579    +3     
+ Misses       2230     2229    -1     
Files with missing lines Coverage Δ
cognite/client/_api/data_modeling/views.py 95.74% <ø> (ø)
...te/client/data_classes/data_modeling/data_types.py 97.09% <100.00%> (ø)
...ite/client/data_classes/data_modeling/instances.py 90.97% <95.23%> (-0.13%) ⬇️
cognite/client/_api/data_modeling/instances.py 87.59% <40.00%> (+0.06%) ⬆️

... and 2 files with indirect coverage changes