Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Script: Glance #575

Closed
wants to merge 30 commits into from
Closed

Conversation

quantumryuu
Copy link
Contributor

Note

We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged.

Description

Created install scripts for Glance
Provide a summary of the changes made and/or reference the issue being addressed.

Fixes # (issue)
#256
Project Board

Type of change

Please check the relevant option(s):

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts.)

Prerequisites

The following efforts must be made for the PR to be considered. Please check when completed:

  • Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
  • Testing performed (I have tested my changes, ensuring everything works as expected)
  • Documentation updated (I have updated any relevant documentation)

Additional Information (optional)

Provide any additional context or screenshots about the feature or fix here.
YML example taken from official repo.

Related Pull Requests / Discussions

If there are other pull requests or discussions related to this change, please link them here:

  • Related PR #

@quantumryuu quantumryuu requested a review from a team as a code owner November 28, 2024 23:49
@github-actions github-actions bot added new script A change that adds a new script website A change to the website labels Nov 28, 2024
Copy link
Member

@MickLesk MickLesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some little comments

ct/glance.sh Show resolved Hide resolved
install/glance-install.sh Outdated Show resolved Hide resolved
install/glance-install.sh Outdated Show resolved Hide resolved
install/glance-install.sh Show resolved Hide resolved
ct/glance.sh Show resolved Hide resolved
ct/glance.sh Show resolved Hide resolved
install/glance-install.sh Outdated Show resolved Hide resolved
@MickLesk MickLesk self-requested a review November 29, 2024 13:26
MickLesk
MickLesk previously approved these changes Nov 29, 2024
@quantumryuu
Copy link
Contributor Author

quantumryuu commented Nov 29, 2024

Made the config yml smaller, added a # on top with the link of documentation!
Corrected everything, should be almost good to go I guess?

@quantumryuu quantumryuu deleted the glance branch November 29, 2024 23:15
@quantumryuu quantumryuu restored the glance branch November 29, 2024 23:15
@quantumryuu quantumryuu mentioned this pull request Nov 30, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new script A change that adds a new script website A change to the website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants