New Script: Apache Guacamole

[michelroegl-brunner]

Note

We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged.

Description

New Script for Apache Guacamole.
At the moment i have no Update funktion implemented, it seems it can lead to many issues to do this automaticly, but i will figure it out and create a new PR for this feature.

Fixes #656

Type of change

Please check the relevant option(s):

• Bug fix (non-breaking change that resolves an issue)
• New feature (non-breaking change that adds functionality)
• Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
• New script (a fully functional and thoroughly tested script or set of scripts.)

Prerequisites

The following efforts must be made for the PR to be considered. Please check when completed:

• Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
• Testing performed (I have tested my changes, ensuring everything works as expected)
• Documentation updated (I have updated any relevant documentation)

Additional Information (optional)

Provide any additional context or screenshots about the feature or fix here.

Related Pull Requests / Discussions

If there are other pull requests or discussions related to this change, please link them here:

• Related PR #

[MickLesk]

Phew, the script is terrible 😄 spelling mistakes and various violations of the conventions. Have a look at other current scripts. I just got a real headache trying to follow the script.

The following:

1. installing dependencies
2. setup database
3. setup Tomcat
4. setup Guacamole
5. creating service
6. cleanup

Use STD only when absolutely necessary, wget, curl, unzip and so on support -q

Then please do not use variable paths, but fixed paths.

[michelroegl-brunner]

Phew, the script is terrible 😄 spelling mistakes and various violations of the conventions. Have a look at other current scripts. I just got a real headache trying to follow the script.

The following:

1. installing dependencies
2. setup database
3. setup Tomcat
4. setup Guacamole
5. creating service
6. cleanup

Use STD only when absolutely necessary, wget, curl, unzip and so on support -q

Then please do not use variable paths, but fixed paths.

First of all thank you for your honesty :D I´m still trying to get the gist of this codebase an highly appreciate the time and effort you put in this reviews and the whole project.
This was a big script for me and i work in all the changes tomorrow!

[michelroegl-brunner]

Updated to account for the changes. Test it on my dev branch with bash -c "$(wget -qLO -https://raw.githubusercontent.com/michelroegl-brunner/ProxmoxVE/refs/heads/DEV/ct/apache-guacamole.sh)"

[MickLesk]

if you have no update function, check adguard.sh (ct), otherwise the user will not get any feedback

[MickLesk]

Error: ENOENT: no such file or directory, stat '/ct/apache-guacamole.sh'

json issue, idk why

[michelroegl-brunner]

Error: ENOENT: no such file or directory, stat '/ct/apache-guacamole.sh'

json issue, idk why

I´ve also seen this. Maybe an issue with the frontend workflow? It probably checks the main branch and there can never be such a file when its a PR with a new script.

I have also added the update_function() as requested.

[MickLesk]

@havardthom can you check the workflow? i dont see any json issue here? 😄

[MickLesk]

ive see the issue now.
its an unneeded / in script

@BramSuurdje can you check it?

json-editor (https://community-scripts.github.io/ProxmoxVE/json-editor):

[MickLesk]

The script has now been finalized. I have optimized it a little and tested it in the DEV branch. The script is a bit special because we have to use various sources here.

can be tested here:

bash -c "$(wget -qLO - https://raw.githubusercontent.com/community-scripts/ProxmoxVE/refs/heads/develop/ct/apache-guacamole.sh)"

@CrazyWolf13 | @IVRYSimon | @trucke
Can you check it? I don't really know the use-case, I just see an empty board where I have to add connections. idk what I have to do :D

Edit: Please only test, if its okay, you can delete the lxc after this, and we merge to main

[joe-heaton]

Happy to test if that's ok?
Have used this app before so something to base off 👍🏻

[michelroegl-brunner]

Happy to test if that's ok?
Have used this app before so something to base off 👍🏻

Yes please, highly appreciated :)

[CrazyWolf13]

@michelroegl-brunner @MickLesk Any reason this contains Snipe-IT ?

[MickLesk]

I think Copy Paste issue. I Update it

[trucke]

The script has now been finalized. I have optimized it a little and tested it in the DEV branch. The script is a bit special because we have to use various sources here.

can be tested here:

bash -c "$(wget -qLO - https://raw.githubusercontent.com/community-scripts/ProxmoxVE/refs/heads/develop/ct/apache-guacamole.sh)"

@CrazyWolf13 | @IVRYSimon | @trucke Can you check it? I don't really know the use-case, I just see an empty board where I have to add connections. idk what I have to do :D

Edit: Please only test, if its okay, you can delete the lxc after this, and we merge to main

sorry for my late reply, unfortunately i'm sick in bed at the moment. i will test it as soon as i can.
thanks guys for your hard and diligent work.

[CrazyWolf13]

@MickLesk Sorry for the delay in testing, had to get my pve cluster fixed first.

TLDR: For me it's compledtely not working!

For me adding a remote connection, for example VNC, immediately fails:

A connection with the exact same settings from my prod guacamole works just fine.
SSH connections fail as well immediately, so I guess there must be some sort of problem between guacd and guac frontend.

Normally this command enables guacd with debug logs to cli, however absolutely 0 logs appear here:

systemctl stop guacd
/usr/local/sbin/guacd -L debug -f

Maybe we can use inspiration at this code: https://github.com/itiligent/Easy-Guacamole-Installer

Log entry from tomcat, /opt/apache-guacamole/tomcat9/logs/catalina.out

20:32:55.543 [http-nio-8080-exec-7] ERROR o.a.g.w.GuacamoleWebSocketTunnelEndpoint - Creation of WebSocket tunnel to guacd failed: java.net.ConnectException: Connection refused
20:32:55.700 [http-nio-8080-exec-10] ERROR o.a.g.s.GuacamoleHTTPTunnelServlet - HTTP tunnel request failed: java.net.ConnectException: Connection refused

[CrazyWolf13]

@MickLesk @joe-heaton @michelroegl-brunner @trucke

Was any of you able to get guacamole working?