ccruntime: Improvements on the runtime classes we deploy #420
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,20 +20,23 @@ patches: | |
| path: /spec/config/runtimeClasses | ||
| value: | ||
| - name: "kata-clh" | ||
| snapshotter: "" | ||
| pulltype: "" | ||
| - name: "kata-qemu" | ||
| snapshotter: "" | ||
| pulltype: "" | ||
| - name: "kata-qemu-coco-dev" | ||
| snapshotter: "nydus" | ||
| pulltype: "guest-pull" | ||
| - name: "kata-qemu-tdx" | ||
| snapshotter: "nydus" | ||
| pulltype: "guest-pull" | ||
|
There was a problem hiding this comment. Hi @fidencio ! We don't test TDX/SEV/SNP with CRI-O so I left this empty on purpose. But it was a mistake, we better have it set to guest-pull anyway, hence, thanks for the fix! BTW, do you plan to test TDX + CRI-O? There is this #409 and I asked on last CI meeting if platform folks would like to test with CRI-O (I didn't get a 'yes' nor 'no'...) There was a problem hiding this comment. Right now we're struggling to have machines available to test. There was a problem hiding this comment. Got it. yeah, it would be trick to use same machine to containerd and cri-o and keep switching the configurations.... |
||
| - name: "kata-qemu-sev" | ||
| snapshotter: "nydus" | ||
| pulltype: "guest-pull" | ||
| - name: "kata-qemu-snp" | ||
| snapshotter: "nydus" | ||
| pulltype: "guest-pull" | ||
| - op: add | ||
| path: /spec/config/defaultRuntimeClassName | ||
| value: "kata-qemu" | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, this was on my TODO list, thanks!
I plan to create a job to test that runtimeclass too: #409 . But let me know if you are already working on that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not working on that, just had to add this for a personal test earlier Today, and shared as I had that done already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fidencio might I ask why on TEE you want nydus and on non-TEE you don't? Also you mentioned in kata there are the defaults, is it possible to rely on those defaults and not setting it here? (would empty string result in using the default or is this not technically possible?)