ccruntime: Improvements on the runtime classes we deploy #420
Conversation
Right now, for some reason, we're not setting TEEs to use guest-pull, although we do that on the Kata Containers side. This is done in order to ensure those would also work when testing using CRI-O, as done for peer-pods. Signed-off-by: Fabiano Fidêncio <[email protected]>
As folks may want to give it a try on non-TEE environments. Signed-off-by: Fabiano Fidêncio <[email protected]>
As those are non-TEE and work better with whatever is the default on the Kata Containers side (virtio-fs, in this case). Signed-off-by: Fabiano Fidêncio <[email protected]>
| @@ -27,13 +27,13 @@ patches: | |||
| pulltype: "" | |||
| - name: "kata-qemu-tdx" | |||
| snapshotter: "nydus" | |||
| pulltype: "" | |||
| pulltype: "guest-pull" | |||
There was a problem hiding this comment.
Hi @fidencio !
We don't test TDX/SEV/SNP with CRI-O so I left this empty on purpose. But it was a mistake, we better have it set to guest-pull anyway, hence, thanks for the fix!
BTW, do you plan to test TDX + CRI-O? There is this #409 and I asked on last CI meeting if platform folks would like to test with CRI-O (I didn't get a 'yes' nor 'no'...)
There was a problem hiding this comment.
Right now we're struggling to have machines available to test.
This, however, helps me when doing tests for Red Hat related stuff. ;-)
There was a problem hiding this comment.
Got it. yeah, it would be trick to use same machine to containerd and cri-o and keep switching the configurations....
| @@ -25,6 +25,9 @@ patches: | |||
| - name: "kata-qemu" | |||
| snapshotter: "nydus" | |||
| pulltype: "" | |||
| - name: "kata-qemu-coco-dev" | |||
There was a problem hiding this comment.
Hey, this was on my TODO list, thanks!
I plan to create a job to test that runtimeclass too: #409 . But let me know if you are already working on that.
There was a problem hiding this comment.
I am not working on that, just had to add this for a personal test earlier Today, and shared as I had that done already.
There was a problem hiding this comment.
@fidencio might I ask why on TEE you want nydus and on non-TEE you don't? Also you mentioned in kata there are the defaults, is it possible to rely on those defaults and not setting it here? (would empty string result in using the default or is this not technically possible?)
Please, see each commit message for more description.