-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
td-layout: support large payload #693
Open
gaojiaqi7
wants to merge
1
commit into
confidential-containers:main
Choose a base branch
from
gaojiaqi7:0510/td_layout_support_large_payload
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,6 +7,8 @@ | |
/* | ||
Image Layout | ||
+----------------------------------------+ <- 0x0 | ||
| LARGE_PAYLOAD | (0x0) 0 B | ||
+----------------------------------------+ <- 0x0 | ||
| CONFIG | (0x40000) 256 kB | ||
+----------------------------------------+ <- 0x40000 | ||
| MAILBOX | (0x1000) 4 kB | ||
|
@@ -29,6 +31,10 @@ Image size: 0x1000000 (16 MB) | |
*/ | ||
|
||
// Image Layout Configuration | ||
pub const TD_SHIM_FIRMWARE_SIZE: u32 = 0x1000000; | ||
|
||
pub const TD_SHIM_LARGE_PAYLOAD_OFFSET: u32 = 0x0; | ||
pub const TD_SHIM_LARGE_PAYLOAD_SIZE: u32 = 0x0; // 0 B | ||
|
||
pub const TD_SHIM_CONFIG_OFFSET: u32 = 0x0; | ||
pub const TD_SHIM_CONFIG_SIZE: u32 = 0x40000; // 256 kB | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why change KB to kB? |
||
|
@@ -57,16 +63,14 @@ pub const TD_SHIM_IPL_SIZE: u32 = 0x349000; // 3.29 MB | |
pub const TD_SHIM_RESET_VECTOR_OFFSET: u32 = 0xFF8000; | ||
pub const TD_SHIM_RESET_VECTOR_SIZE: u32 = 0x8000; // 32 kB | ||
|
||
// Offset when Loading into Memory | ||
pub const TD_SHIM_FIRMWARE_BASE: u32 = 0xFF000000; | ||
pub const TD_SHIM_FIRMWARE_SIZE: u32 = 0x1000000; | ||
|
||
// TD_SHIM_SEC_INFO_OFFSET equals to firmware size - metadata pointer offset - | ||
// OVMF GUID table size - SEC Core information size. | ||
pub const TD_SHIM_SEC_CORE_INFO_OFFSET: u32 = 0xFFFFAC; | ||
pub const TD_SHIM_SEC_CORE_INFO_BASE: u32 = 0xFFFFFFAC; | ||
|
||
// Base Address after Loaded into Memory | ||
// Rom Configuration | ||
|
||
pub const TD_SHIM_FIRMWARE_BASE: u32 = 0xFF000000; | ||
pub const TD_SHIM_CONFIG_BASE: u32 = 0xFF000000; | ||
pub const TD_SHIM_MAILBOX_BASE: u32 = 0xFF040000; | ||
pub const TD_SHIM_TEMP_STACK_BASE: u32 = 0xFF041000; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why change KB to kB?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is generated with a third-party crate which changes its size format.