td-layout: support large payload #693
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaojiaqi7
force-pushed
the
0510/td_layout_support_large_payload
branch
2 times, most recently
from
714ab42 to
25c7cdd
Compare
jyao1
reviewed
May 20, 2024
| +----------------------------------------+ <- 0x40000 | ||
| | MAILBOX | (0x1000) 4 KB | ||
| | MAILBOX | (0x1000) 4 kB |
There was a problem hiding this comment.
This file is generated with a third-party crate which changes its size format.
jyao1
reviewed
May 20, 2024
|
|
||
| pub const TD_SHIM_CONFIG_OFFSET: u32 = 0x0; | ||
| pub const TD_SHIM_CONFIG_SIZE: u32 = 0x40000; // 256 KB | ||
| pub const TD_SHIM_CONFIG_SIZE: u32 = 0x40000; // 256 kB |
jyao1
reviewed
May 20, 2024
td-layout/src/build_time.rs
Outdated
|
|
||
| pub const TD_SHIM_PAYLOAD_OFFSET: u32 = 0x82000; | ||
| pub const TD_SHIM_PAYLOAD_OFFSET: u32 = 0x81000; | ||
| pub const TD_SHIM_PAYLOAD_SIZE: u32 = 0xC2D000; // 12.18 MB |
There was a problem hiding this comment.
You can increase PAYLOAD_SIZE to avoid other changes.
There was a problem hiding this comment.
Also, please split the "Free Section Removal" change from "Large Payload" change.
Update the `td-layout` with `td-layout-config`. Signed-off-by: Jiaqi Gao <[email protected]>
gaojiaqi7
force-pushed
the
0510/td_layout_support_large_payload
branch
from
25c7cdd to
530cdfc
Compare
jyao1
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the
td-layoutwithtd-layout-config.