ghactions: Misc cleanups #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will ensure they get into our release assets, and may eventually help removing manual builds from podman Makefile: https://github.com/containers/podman/blob/2806378c1a21f3ed55dfff2f32ef98ab0d9eec23/Makefile#L775-L787 After this commit, we'll build both gvproxy-windows.exe and gvproxy-windowsgui.exe, the former can be started from a console, and the latter will run in the background. Signed-off-by: Christophe Fergeau <[email protected]>
The manual `go build` invocation is duplicating what is already being done in the Makefile Signed-off-by: Christophe Fergeau <[email protected]>
The macOS version should not matter for our tests. If we don't hardcode a version, we don't need to update it ourselves when it's obsoleted. Signed-off-by: Christophe Fergeau <[email protected]>
It's used on purpose, see commit 428c400 and containers#256 Signed-off-by: Christophe Fergeau <[email protected]>
|
/lgtm |
praveenkumar
approved these changes
Sep 22, 2023
| @@ -9,7 +9,7 @@ on: | |||
| jobs: | |||
|
|
|||
| build: | |||
| runs-on: ubuntu-20.04 | |||
| runs-on: ubuntu-20.04 # explicitly use 20.04, see commit 428c40018a | |||
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau, praveenkumar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gbraad
reviewed
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal is to have win-sshproxy and gvproxy build with -Hwindowsgui as part of our build artifacts.
This makes them easier to include in our releases, and to provide them for use by podman.