Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghactions: Misc cleanups #274

Merged
merged 4 commits into from
Sep 22, 2023
Merged

ghactions: Misc cleanups #274

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2b338d6
ghactions: build: Add win-gvproxy and win-sshproxy
cfergeau Sep 6, 2023
395e234
ghactions: Use `make win-sshproxy`
cfergeau Sep 6, 2023
2f26014
ghactions: Use macos-latest instead of macos-11
cfergeau Sep 6, 2023
b1731b1
ghactions: Add comment explaining why we stay on ubuntu-20.04
cfergeau Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .github/workflows/go.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:
jobs:

build:
runs-on: ubuntu-20.04
runs-on: ubuntu-20.04 # explicitly use 20.04, see commit 428c40018a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

timeout-minutes: 30
steps:
- uses: actions/checkout@v3
Expand All @@ -20,15 +20,17 @@ jobs:
go-version: 1.20.x

- name: Build
run: make cross qemu-wrapper vm
run: |
make cross qemu-wrapper vm win-gvproxy win-sshproxy
mv bin/gvproxy.exe bin/gvproxy-windowsgui.exe

- uses: actions/upload-artifact@v3
with:
name: gvisor-tap-vsock-binaries
path: bin/*

tests:
runs-on: macos-11 # Only Mac runners support nested virt
runs-on: macos-latest # Only Mac runners support nested virt
needs: build # Don't bother testing if cross arch build fails
timeout-minutes: 30
steps:
Expand Down Expand Up @@ -65,7 +67,7 @@ jobs:
go-version: 1.20.x

- name: Build
run: go build -ldflags -H=windowsgui -o bin/win-sshproxy.exe ./cmd/win-sshproxy
run: make win-sshproxy

- name: Test
run: go test -v .\test-win-sshproxy
Expand Down