Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Unix URL handling in ssh_forwarder #372

Closed
wants to merge 1 commit into from

Conversation

arixmkii
Copy link
Contributor

Fixes #371

This platform specific handling seems not to do what it was originally intended to. See details in the original issue.

Copy link

We were not able to find or create Copr project packit/containers-gvisor-tap-vsock-372 specified in the config with the following error:

Packit received HTTP 500 Internal Server Error from Copr Service. Check the Copr status page: https://copr.fedorainfracloud.org/status/stats/, or ask for help in Fedora Build System matrix channel https://matrix.to/#/#buildsys:fedoraproject.org.

Unless the HTTP status code above is >= 500, please check your configuration for:

  1. typos in owner and project name (groups need to be prefixed with @)
  2. whether the project name doesn't contain not allowed characters (only letters, digits, underscores, dashes and dots must be used)
  3. whether the project itself exists (Packit creates projects only in its own namespace)
  4. whether Packit is allowed to build in your Copr project
  5. whether your Copr project/group is not private

Copy link
Contributor

openshift-ci bot commented Jul 19, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: arixmkii
Once this PR has been reviewed and has the lgtm label, please assign baude for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@arixmkii
Copy link
Contributor Author

@n1hility may be you can take a look. It came from your commit. Might be it was covering some old behavior, which is not present in the std lib anymore.

@cfergeau
Copy link
Collaborator

@n1hility may be you can take a look. It came from your commit. Might be it was covering some old behavior, which is not present in the std lib anymore.

I wrote a detailed answer in #371, but the TrimPrefix is required when you use an URI such as unix:///C:/foo.ext

@cfergeau
Copy link
Collaborator

/hold

@arixmkii
Copy link
Contributor Author

@cfergeau Thank you! I will test in details. Converted this PR into draft and will close if it works as you described.

@arixmkii
Copy link
Contributor Author

Was fixing the wrong part

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unix socket forwarding issue on Windows platform
2 participants