Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use all configured ipv4 dns services #426

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

evidolob
Copy link
Contributor

Fixes #398

@evidolob evidolob requested a review from cfergeau November 15, 2024 13:12
@evidolob
Copy link
Contributor Author

cc @lstocchi

@evidolob evidolob force-pushed the use-all-dns branch 3 times, most recently from 397eace to e9dc64b Compare November 15, 2024 13:28
Copy link
Collaborator

@cfergeau cfergeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a few minor questions/suggestions.

pkg/services/dns/dns_config_windows.go Outdated Show resolved Hide resolved
pkg/services/dns/dns_config_unix.go Outdated Show resolved Hide resolved
It brings all ipv4 dns and make dns resolve request one by one until it receives first answer

Signed-off-by: Yevhen Vydolob <[email protected]>
@cfergeau
Copy link
Collaborator

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Nov 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau, evidolob

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 2be6b3f into containers:main Nov 15, 2024
19 of 20 checks passed
@evidolob evidolob deleted the use-all-dns branch November 28, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DNS forwarding code only handles the first name server
2 participants