Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tqdm dependency #523

Merged
merged 1 commit into from
Dec 22, 2024
Merged

Conversation

swarajpande5
Copy link
Contributor

@swarajpande5 swarajpande5 commented Dec 22, 2024

This PR removes the tqdm dependency, and updates all the mentions of the same.

Summary by Sourcery

Remove the tqdm dependency.

Enhancements:

  • Update installation instructions to remove tqdm.

Build:

  • Remove tqdm from the RPM build dependencies.

CI:

  • Remove tqdm installation step from CI workflows.

Tests:

  • Remove tqdm from installation requirements.

Signed-off-by: swarajpande5 <[email protected]>
Copy link
Contributor

sourcery-ai bot commented Dec 22, 2024

Reviewer's Guide by Sourcery

This PR removes the tqdm dependency and updates all related code and documentation.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Removed the tqdm dependency.
  • Removed tqdm from build requirements.
  • Removed tqdm installation step from CI workflows.
  • Removed tqdm from installation instructions.
  • Removed tqdm from project dependencies.
rpm/python-ramalama.spec
.github/workflows/ci.yml
Makefile
pyproject.toml
Updated documentation and code to reflect the removal of tqdm.
  • Updated installation instructions to remove tqdm from the list of dependencies.
ramalama/huggingface.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@swarajpande5 swarajpande5 marked this pull request as ready for review December 22, 2024 13:32
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @swarajpande5 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Could you explain the motivation for removing tqdm? Was it unused, or is the progress bar functionality being replaced with an alternative solution?
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ericcurtin
Copy link
Collaborator

I think we may have fixed one of the broken builds removing this dependency

@ericcurtin ericcurtin merged commit 3c8c0bd into containers:main Dec 22, 2024
11 checks passed
@swarajpande5 swarajpande5 deleted the remove-tqdm branch December 22, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants