Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tqdm dependency #523

Merged
merged 1 commit into from
Dec 22, 2024
Merged

Remove tqdm dependency #523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ jobs:
sudo apt-get update
sudo apt-get install podman bats bash codespell python3-argcomplete pipx
make install-requirements
pip install tqdm --break-system-packages

- name: Upgrade to podman 5
run: |
Expand Down Expand Up @@ -57,7 +56,6 @@ jobs:

- name: bats-nocontainer
run: |
pip install tqdm --break-system-packages
make bats-nocontainer

docker:
Expand Down Expand Up @@ -103,7 +101,6 @@ jobs:
- name: bats-docker
run: |
docker info
pip install tqdm --break-system-packages
make bats-docker

macos:
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ help:

.PHONY: install-requirements
install-requirements:
pipx install tqdm black flake8 argcomplete wheel omlmd huggingface_hub codespell
pipx install black flake8 argcomplete wheel omlmd huggingface_hub codespell

.PHONY: install-completions
install-completions: completions
Expand Down
1 change: 0 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ name = "ramalama"
version = "0.3.0"
dependencies = [
"argcomplete",
"tqdm",
]
requires-python = ">= 3.8"
maintainers = [
Expand Down
4 changes: 2 additions & 2 deletions ramalama/huggingface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@
from ramalama.model import Model

missing_huggingface = """
Optional: Huggingface models require the huggingface-cli and tqdm modules.
Optional: Huggingface models require the huggingface-cli module.
These modules can be installed via PyPi tools like pip, pip3, pipx, or via
distribution package managers like dnf or apt. Example:
pip install huggingface_hub tqdm
pip install huggingface_hub
"""


Expand Down
5 changes: 0 additions & 5 deletions rpm/python-ramalama.spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,6 @@ BuildRequires: python%{python3_pkgversion}-devel
BuildRequires: python%{python3_pkgversion}-pip
BuildRequires: python%{python3_pkgversion}-setuptools
BuildRequires: python%{python3_pkgversion}-wheel
%if 0%{?fedora} >= 40
BuildRequires: python%{python3_pkgversion}-tqdm
%endif

%description
%summary
Expand All @@ -52,11 +49,9 @@ will run the AI Models within a container based on the OCI image.
%package -n python%{python3_pkgversion}-%{pypi_name}
Requires: podman
%if 0%{?fedora} >= 40
Requires: python%{python3_pkgversion}-tqdm
# Needed as seen by BZ: 2327515
Requires: python%{python3_pkgversion}-omlmd
%else
Recommends: python%{python3_pkgversion}-tqdm
Recommends: python%{python3_pkgversion}-omlmd
%endif
Summary: %{summary}
Expand Down
Loading