Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing files to install.sh script #524

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Add missing files to install.sh script #524

merged 1 commit into from
Dec 23, 2024

Conversation

ericcurtin
Copy link
Collaborator

@ericcurtin ericcurtin commented Dec 22, 2024

file.py , http_client.py , etc.

Summary by Sourcery

Build:

  • Add missing Python files to the install.sh script.

file.py , http_client.py , etc.

Signed-off-by: Eric Curtin <[email protected]>
Copy link
Contributor

sourcery-ai bot commented Dec 22, 2024

Reviewer's Guide by Sourcery

This pull request adds missing files to the install.sh script. The changes ensure that necessary files are included in the installation process. This addresses the issue of missing files in the previous version of the script.

Sequence diagram for updated installation process

sequenceDiagram
    participant User as User
    participant Install as install.sh
    participant Server as Remote Server

    User->>Install: Execute install.sh
    Install->>Install: setup_ramalama()
    loop For each Python file
        Install->>Server: Download file
        Note right of Install: Now includes additional files:
        Note right of Install: file.py, http_client.py,
        Note right of Install: url.py, annotations.py
        Server-->>Install: Return file content
        Install->>Install: Install file
    end
Loading

File-Level Changes

Change Details Files
Added missing Python files to the installation script.
  • Added file.py, http_client.py, url.py, and annotations.py to the list of installed files in the install.sh script.
  • Modified the python_files array to include the newly added files.
  • Updated the installation loop to handle the additional files and ensure they are downloaded and installed correctly during setup_ramalama() execution.
install.sh

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ericcurtin - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please expand the PR description to explain why these files are being added and what functionality they provide. This helps reviewers and future maintainers understand the context of the change.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

local python_files=("cli.py" "huggingface.py" "model.py" "ollama.py" "common.py" "__init__.py" \
"quadlet.py" "kube.py" "oci.py" "version.py" "shortnames.py" "toml_parser.py")

local python_files=("cli.py" "huggingface.py" "model.py" "ollama.py" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be easier to just use a GLOB for this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way this installer works is it pulls down install.sh via curl and then the various other files it needs via curl. We could maybe pull down the whole project as a zip/tarball , etc. and then do a glob, but we would pull a lot of unnecessary things also.

But yeah I've also been thinking maybe we can look into somehow making this smarter rather than listing all the files.

@rhatdan
Copy link
Member

rhatdan commented Dec 23, 2024

Merging but I think we should open a PR to just grab the py files in the ramalama/*py.

@rhatdan rhatdan merged commit 0b11f9b into main Dec 23, 2024
11 checks passed
@ericcurtin ericcurtin deleted the new-files branch December 23, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants