Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing files to install.sh script #524

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Add missing files to install.sh script #524

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,11 @@ setup_ramalama() {
$sudo install -m755 -d "$syspath"
$sudo install -m755 "$to_file" "$ramalama_bin"

local python_files=("cli.py" "huggingface.py" "model.py" "ollama.py" "common.py" "__init__.py" \
"quadlet.py" "kube.py" "oci.py" "version.py" "shortnames.py" "toml_parser.py")

local python_files=("cli.py" "huggingface.py" "model.py" "ollama.py" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be easier to just use a GLOB for this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way this installer works is it pulls down install.sh via curl and then the various other files it needs via curl. We could maybe pull down the whole project as a zip/tarball , etc. and then do a glob, but we would pull a lot of unnecessary things also.

But yeah I've also been thinking maybe we can look into somehow making this smarter rather than listing all the files.

"common.py" "__init__.py" "quadlet.py" "kube.py" \
"oci.py" "version.py" "shortnames.py" "toml_parser.py" \
"file.py" "http_client.py" "url.py" "annotations.py")

for i in "${python_files[@]}"; do
url="${host}/containers/ramalama/${branch}/ramalama/${i}"
download "$url" "$to_file"
Expand Down
Loading