change secret mutation to target tenant secret #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Soule BA <[email protected]>
stefanprodan
reviewed
Mar 8, 2024
| - v1/Namespace | ||
| selector: | ||
| matchLabels: | ||
| toolkit.fluxcd.io/tenant: "apps" |
There was a problem hiding this comment.
I don't think this is the right place to do this, apps is just one of many tenants. A better place for this would be a policy here: https://github.com/controlplaneio-fluxcd/d1-fleet/tree/main/tenants/apps/policies
There was a problem hiding this comment.
hmm, but we have the secret generation there, and the sync to add the token field should happen before that. Anyway this is while we wait for the fix, maybe we should just wait.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed until 745 is fixed.