Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change secret mutation to target tenant secret #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

change secret mutation to target tenant secret #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions components/admission/configs/base/sync-git-token.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,10 @@ spec:
any:
- resources:
kinds:
- Secret
names:
- flux-system
namespaces:
- flux-system
- v1/Namespace
selector:
matchLabels:
toolkit.fluxcd.io/tenant: "apps"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the right place to do this, apps is just one of many tenants. A better place for this would be a policy here: https://github.com/controlplaneio-fluxcd/d1-fleet/tree/main/tenants/apps/policies

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, but we have the secret generation there, and the sync to add the token field should happen before that. Anyway this is while we wait for the fix, maybe we should just wait.

mutate:
targets:
- apiVersion: v1
Expand Down
Loading