Properly load/export/snapshot feeds w/ mixed calendar definitions. #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #287 +/- ##
=========================================
Coverage 65.35% 65.35%
Complexity 880 880
=========================================
Files 135 135
Lines 6743 6749 +6
Branches 794 793 -1
=========================================
+ Hits 4407 4411 +4
- Misses 2037 2038 +1
- Partials 299 300 +1
Continue to review full report at Codecov.
|
landonreed
reviewed
May 19, 2020
src/main/java/com/conveyal/gtfs/loader/JdbcGtfsSnapshotter.java
Outdated
Show resolved
Hide resolved
landonreed
reviewed
May 19, 2020
src/main/java/com/conveyal/gtfs/loader/JdbcGtfsSnapshotter.java
Outdated
Show resolved
Hide resolved
landonreed
reviewed
May 19, 2020
landonreed
reviewed
May 19, 2020
landonreed
reviewed
May 19, 2020
landonreed
reviewed
May 19, 2020
landonreed
reviewed
May 19, 2020
landonreed
reviewed
May 19, 2020
landonreed
reviewed
May 19, 2020
| numRecordsSearched, | ||
| ComparatorMatcherBuilder.<Integer>usingNaturalOrdering().greaterThan(0) | ||
| ); | ||
| if (mismatches != null) { | ||
| if (!foundRecord && mismatches != null) { |
There was a problem hiding this comment.
Conditional could probably use a comment.
5 tasks
landonreed
approved these changes
May 19, 2020
There was a problem hiding this comment.
@evansiroky, this looks great. I have a few suggestions for improvement which I've included in #288. If those look good to you, we can go ahead and merge.
Mixed calendar definition fix ltr
|
🎉 This PR is included in version 6.0.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
devbefore they can be merged tomaster)Description
Fixes ibi-group/datatools-server#313. When snapshotting feeds with a mixture of calendar definitions (some calendar + calendar_dates and some calendar_date only service_ids), the auto-generated calendar entries weren't being created thus causing problems in datatools. This fixes that and adds a test case to prove it.